Interpolating hues should use rem_euclid. #12641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
A-Rendering
|
A full fix is waiting on #12619 to get merged first. |
|
I'm merging #12619 with the old approach since it is otherwise ready: can you merge main in (in about 10 minutes) and then clean up that code here? |
Also, added additional tests for the hue interpolation. Fixes bevyengine#12632 Fixes bevyengine#12631
ItsDoot
removed
the
S-Blocked
alice-i-cecile
approved these changes
Mar 22, 2024
pablo-lua
approved these changes
Mar 22, 2024
pablo-lua
added
the
S-Ready-For-Final-Review
NthTensor
approved these changes
Mar 22, 2024
|
@alice-i-cecile Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, added additional tests for the hue interpolation.
Fixes #12632
Fixes #12631