Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix mesh2d_manual example #15862

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix mesh2d_manual example #15862

wants to merge 2 commits into from
+3 −4

Conversation

awtterpip
Copy link
Contributor

Objective

Solution

  • Change mesh2d_manual to use the proper vertex format for color.

Testing

  • The mesh2d_manual example now works for me, tested on linux

@awtterpip awtterpip mentioned this pull request Oct 12, 2024
Open
@alice-i-cecile alice-i-cecile added this to the 0.15 milestone Oct 12, 2024
@alice-i-cecile alice-i-cecile added A-Rendering Drawing game state to the screen C-Examples An addition or correction to our examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Oct 12, 2024
@rparrett rparrett requested a review from Jondolf October 12, 2024 00:29
rparrett
rparrett reviewed Oct 12, 2024
View reviewed changes
examples/2d/mesh2d_manual.rs Outdated
@@ -264,7 +264,7 @@ fn vertex(vertex: Vertex) -> VertexOutput {
let model = mesh2d_functions::get_world_from_local(vertex.instance_index);
out.clip_position = mesh2d_functions::mesh2d_position_local_to_clip(model, vec4<f32>(vertex.position, 1.0));
// Unpack the `u32` from the vertex buffer into the `vec4<f32>` used by the fragment shader
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment is no longer needed

@rparrett
Copy link
Contributor

rparrett commented Oct 12, 2024 •
edited
Loading

This looks good, but I'm curious about why we changed the vertex attribute format in that migration. I had the impression that we were intentionally using a custom vertex attribute in that example, but I could very easily be mistaken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile left review comments

@Jondolf Jondolf Awaiting requested review from Jondolf

@IceSentry IceSentry Awaiting requested review from IceSentry

@rparrett rparrett Awaiting requested review from rparrett

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Examples An addition or correction to our examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward
Projects
Rendering
Status: No status
Milestone
0.15
Development

Successfully merging this pull request may close these issues.

mesh2d_manual example doesn't render correctly
3 participants
@awtterpip @rparrett @alice-i-cecile