Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: patch ir diff #153

Merged
merged 4 commits into from
Aug 14, 2024
Merged

fix: patch ir diff #153

merged 4 commits into from
Aug 14, 2024

Conversation

sakulstra
Copy link
Contributor

@sakulstra sakulstra commented Aug 14, 2024 •
edited
Loading

There's currently two bugs on the report diff:

  • when the ir params change it does not show up in the diff. The reason is that in 3.0 irs were immutable and we checked for the address to change in order to diff it. Does no longer works with 3.1 as address will not change.
  • when an eMode params change we didn't render a diff (only when an asset category changed)

@sakulstra sakulstra merged commit bd6f8bb into main Aug 14, 2024
2 checks passed
@sakulstra sakulstra deleted the fix/ir-diff-patch branch August 14, 2024 14:40
@github-actions github-actions bot mentioned this pull request Aug 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sendra sendra sendra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sakulstra @sendra