fix: patch ir diff

src/reports/__snapshots__/report.spec.ts.snap

@@ -296,7 +296,7 @@ exports[`report > should generate a well formatted report 1`] = `
 \`\`\`"
 `;
 
-exports[`report > should generate a well formatted report for 3.1 1`] = `
+exports[`report > should generate a well formatted report for 3.0 to 3.1 1`] = `
 "## Reserve changes
 
 ### Reserve altered
@@ -439,3 +439,93 @@ exports[`report > should generate a well formatted report for 3.1 1`] = `
 }
 \`\`\`"
 `;
+
+exports[`report > should generate a well formatted report for 3.1 1`] = `
+"## Reserve changes
+
+### Reserve altered
+
+#### GHO ([0x40D16FC0246aD3160Ccc09B8D0D3A2cD28aE6C2f](https://etherscan.io/address/0x40D16FC0246aD3160Ccc09B8D0D3A2cD28aE6C2f))
+
+| description | value before | value after |
+| --- | --- | --- |
+| maxVariableBorrowRate | 7 % | 6 % |
+| baseVariableBorrowRate | 7 % | 6 % |
+| interestRate | ![before](/.assets/e03975867d1c729d1a52bbec364211baff2dab5a.svg) | ![after](/.assets/a1a7ab1f1b9fcdf6ffa41ac7a8b4daf2daf98328.svg) |
+
+#### wstETH ([0x7f39C581F595B53c5cb19bD0b3f8dA6c935E2Ca0](https://etherscan.io/address/0x7f39C581F595B53c5cb19bD0b3f8dA6c935E2Ca0))
+
+| description | value before | value after |
+| --- | --- | --- |
+| eMode.liquidationBonus | 1 % | 2 % |
+
+
+#### ETHx ([0xA35b1B31Ce002FBF2058D22F30f95D405200A15b](https://etherscan.io/address/0xA35b1B31Ce002FBF2058D22F30f95D405200A15b))
+
+| description | value before | value after |
+| --- | --- | --- |
+| eMode.liquidationBonus | 1 % | 2 % |
+
+
+#### cbETH ([0xBe9895146f7AF43049ca1c1AE358B0541Ea49704](https://etherscan.io/address/0xBe9895146f7AF43049ca1c1AE358B0541Ea49704))
+
+| description | value before | value after |
+| --- | --- | --- |
+| eMode.liquidationBonus | 1 % | 2 % |
+
+
+#### WETH ([0xC02aaA39b223FE8D0A0e5C4F27eAD9083C756Cc2](https://etherscan.io/address/0xC02aaA39b223FE8D0A0e5C4F27eAD9083C756Cc2))
+
+| description | value before | value after |
+| --- | --- | --- |
+| eMode.liquidationBonus | 1 % | 2 % |
+
+
+#### weETH ([0xCd5fE23C85820F7B72D0926FC9b05b43E359b7ee](https://etherscan.io/address/0xCd5fE23C85820F7B72D0926FC9b05b43E359b7ee))
+
+| description | value before | value after |
+| --- | --- | --- |
+| eMode.liquidationBonus | 1 % | 2 % |
+
+
+#### rETH ([0xae78736Cd615f374D3085123A210448E74Fc6393](https://etherscan.io/address/0xae78736Cd615f374D3085123A210448E74Fc6393))
+
+| description | value before | value after |
+| --- | --- | --- |
+| eMode.liquidationBonus | 1 % | 2 % |
+
+
+#### osETH ([0xf1C9acDc66974dFB6dEcB12aA385b9cD01190E38](https://etherscan.io/address/0xf1C9acDc66974dFB6dEcB12aA385b9cD01190E38))
+
+| description | value before | value after |
+| --- | --- | --- |
+| eMode.liquidationBonus | 1 % | 2 % |
+
+
+## Raw diff
+
+\`\`\`json
+{
+ "eModes": {
+ "1": {
+ "liquidationBonus": {
+ "from": 10100,
+ "to": 10200
+ }
+ }
+ },
+ "strategies": {
+ "0x40D16FC0246aD3160Ccc09B8D0D3A2cD28aE6C2f": {
+ "baseVariableBorrowRate": {
+ "from": "70000000000000000000000000",
+ "to": "60000000000000000000000000"
+ },
+ "maxVariableBorrowRate": {
+ "from": "70000000000000000000000000",
+ "to": "60000000000000000000000000"
+ }
+ }
+ }
+}
+\`\`\`"
+`;

src/reports/diff-reports.ts

@@ -6,6 +6,16 @@ import {renderReserve, renderReserveDiff} from './reserve';
 import {AaveV3Reserve, type AaveV3Snapshot} from './snapshot-types';
 import {renderStrategy, renderStrategyDiff} from './strategy';
 
+function hasDiff(input: Record<string, any>): boolean {
+ if (!input) return false;
+ return !!Object.keys(input).find(
+ (key) =>
+ typeof input[key as keyof typeof input] === 'object' &&
+ (input[key as keyof typeof input].hasOwnProperty('from') ||
+ input[key as keyof typeof input].hasOwnProperty('to')),
+ );
+}
+
 export async function diffReports<A extends AaveV3Snapshot, B extends AaveV3Snapshot>(
  pre: A,
  post: B,
@@ -53,26 +63,35 @@ export async function diffReports<A extends AaveV3Snapshot, B extends AaveV3Snap
  .filter((i) => i);
  const reservesAltered = Object.keys(diffResult.reserves)
  .map((reserveKey) => {
- // from being present on key means reserve was removed
- if (
- !(diffResult.reserves[reserveKey] as any).hasOwnProperty('from') &&
- Object.keys(diffResult.reserves[reserveKey]).find(
- (fieldKey) => typeof (diffResult.reserves as any)[reserveKey][fieldKey] === 'object',
+ // "from" being present on reserses key means reserve was removed
+ if (!(diffResult.reserves[reserveKey] as any).hasOwnProperty('from')) {
+ const hasChangedReserveProperties = hasDiff(diffResult.reserves[reserveKey]);
+ const preIrHash = hash(pre.strategies[reserveKey]);
+ const postIrHash = hash(post.strategies[reserveKey]);
+ const hasChangedIr = preIrHash !== postIrHash;
+ const eModeCategoryChanged =
+ diffResult.reserves[reserveKey].eModeCategory?.hasOwnProperty('from');
+ const eModeParamsChanged =
+ !eModeCategoryChanged &&
+ hasDiff(diffResult.eModes?.[diffResult.reserves[reserveKey].eModeCategory as any]);
+ if (
+ !hasChangedReserveProperties &&
+ !hasChangedIr &&
+ !eModeCategoryChanged &&
+ !eModeParamsChanged
  )
- ) {
+  return;
  // diff reserve
  let report = renderReserveDiff(diffResult.reserves[reserveKey] as any, chainId);
  // diff irs
- const preIrHash = hash(pre.strategies[reserveKey]);
- const postIrHash = hash(post.strategies[reserveKey]);
- if (preIrHash !== postIrHash) {
+ if (hasChangedIr) {
  report += renderStrategyDiff(
  diff(pre.strategies[reserveKey], post.strategies[reserveKey]) as any,
  );
  report += `| interestRate | ![before](/.assets/${preIrHash}.svg) | ![after](/.assets/${postIrHash}.svg) |`;
  }
  // diff eModes
- if (diffResult.reserves[reserveKey].eModeCategory?.hasOwnProperty('from')) {
+ if (eModeCategoryChanged) {
  report += renderEmodeDiff(
  diff(
  pre.eModes[(diffResult.reserves[reserveKey].eModeCategory as any).from] || {},
@@ -81,6 +100,15 @@ export async function diffReports<A extends AaveV3Snapshot, B extends AaveV3Snap
  );
  }
 
+ if (eModeParamsChanged && !eModeCategoryChanged) {
+ report += renderEmodeDiff(
+ diff(
+ pre.eModes[diffResult.reserves[reserveKey].eModeCategory as any] || {},
+ post.eModes[diffResult.reserves[reserveKey].eModeCategory as any],
+ ) as any,
+ );
+ }
+
  return report;
  }
  })