-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bitnami/etcd] Add pre-upgrade hook #31161
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Khoi Pham <pckhoi@gmail.com>
Signed-off-by: Khoi Pham <pckhoi@gmail.com>
Thanks for your contribution!! Just so you know, to run our test suite, separate PRs per chart must be created. In this case, two different PRs are required: one for common and another one for etcd. |
Sure, I have just created this one: #31164 |
Signed-off-by: Carlos Rodríguez Hernández <carlosrh@vmware.com>
Signed-off-by: Carlos Rodríguez Hernández <carlosrh@vmware.com>
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
Thanks so much for this great contribution! I added some comments in the associated PR for the container. |
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
…ade hook Signed-off-by: Khoi Pham <pckhoi@gmail.com>
Signed-off-by: Khoi Pham <pckhoi@gmail.com>
Signed-off-by: Khoi Pham <pckhoi@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Please check my comments
Signed-off-by: Khoi Pham <pckhoi@gmail.com>
Signed-off-by: Khoi Pham <pckhoi@gmail.com>
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few extra minor comments. I'll start doing some tests to double-check we're ready to merge both PRs
Signed-off-by: Khoi Pham <pckhoi@gmail.com>
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks so much for applying the feedback.
We won't merge this PR until we release a new container revision including the changes at bitnami/containers#75906 and we update image.tag
in the values.
Description of the change
preupgrade.sh
- a new script added in [bitnami/etcd] Stop relying on files for state containers#75906removeMemberOnContainerTermination
parameterinitialClusterState
parameterBenefits
Benefits are described more extensively in bitnami/containers#75906 but here are the main points:
initialClusterState
parameterPossible drawbacks
Applicable issues
Additional information
Checklist
Chart.yaml
according to semver. This is not necessary when the changes only affect README.md files.README.md
using readme-generator-for-helm