Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bitnami/common] Add "common.capabilities.job.apiVersion" template #31164

Merged
merged 9 commits into from
Jan 3, 2025
Merged

[bitnami/common] Add "common.capabilities.job.apiVersion" template #31164

merged 9 commits into from
Jan 3, 2025
+19 −3

Conversation

pckhoi
Copy link
Contributor

@pckhoi pckhoi commented Dec 26, 2024 •
edited by carrodher
Loading

Description of the change

  • Add "common.capabilities.job.apiVersion" template

Benefits

  • Encapsulate job API version string logic

Applicable issues

It's related to #31161 and bitnami/containers#75906

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

@pckhoi
[bitnami/common] Add "common.capabilities.job.apiVersion" template
bee858b 
Signed-off-by: Khoi Pham <pckhoi@gmail.com>
@github-actions github-actions bot added common triage Triage is needed labels Dec 26, 2024
@github-actions github-actions bot requested a review from carrodher December 26, 2024 08:38
@pckhoi pckhoi mentioned this pull request Dec 26, 2024
Open
4 tasks
@bitnami-bot
Update CHANGELOG.md
4fdcbe0 
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
@carrodher carrodher added verify Execute verification workflow for these changes in-progress labels Dec 27, 2024
@github-actions github-actions bot removed the triage Triage is needed label Dec 27, 2024
@github-actions github-actions bot removed the request for review from carrodher December 27, 2024 07:32
@github-actions github-actions bot requested a review from dgomezleon December 27, 2024 07:32
@bitnami-bot
Update CHANGELOG.md
72ce11f 
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
@carrodher carrodher mentioned this pull request Dec 27, 2024
Open
@carrodher carrodher requested a review from juan131 December 27, 2024 07:38
juan131
juan131 requested changes Dec 30, 2024
View reviewed changes
bitnami/common/templates/_capabilities.tpl Outdated Show resolved Hide resolved
bitnami/common/Chart.yaml Show resolved Hide resolved
pckhoi and others added 3 commits December 30, 2024 16:47
@pckhoi
[bitnami/common] Update appVersion and change function position
66e0312 
Signed-off-by: Khoi Pham <pckhoi@gmail.com>
@pckhoi
Merge branch 'update-common' of github.com:pckhoi/charts into update-…
f3ff97b 
…common
@bitnami-bot
Update CHANGELOG.md
6ff28d0 
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
juan131
juan131 reviewed Dec 30, 2024
View reviewed changes
bitnami/common/Chart.yaml Outdated Show resolved Hide resolved
pckhoi and others added 3 commits January 2, 2025 16:00
@pckhoi
[bitnami/common] Undo description changes
5bae10d 
Signed-off-by: Khoi Pham <pckhoi@gmail.com>
@pckhoi
Merge branch 'update-common' of github.com:pckhoi/charts into update-…
c9d80db 
…common
@bitnami-bot
Update CHANGELOG.md
64486a5 
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
@juan131 juan131 merged commit 2ca979a into bitnami:main Jan 3, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgomezleon dgomezleon dgomezleon approved these changes

@juan131 juan131 juan131 approved these changes

Assignees

@juan131 juan131

@dgomezleon dgomezleon

Labels
common solved verify Execute verification workflow for these changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pckhoi @juan131 @dgomezleon @carrodher @bitnami-bot