-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow accessing frigate with authentication #801
Allow accessing frigate with authentication #801
Conversation
Please ensure the tests pass, then I'll take a look, thanks! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #801 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 17 17
Lines 2077 2140 +63
=========================================
+ Hits 2077 2140 +63 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks for this.
@loispostula This is fantastic, thank you. Few comments added. |
You probably also need to update |
2cd903b
to
920e15d
Compare
@dermotduffy thank you for your review, I've rebased the PR to incorporate the Also I'm not familiar with ha translation, so I can add the translation for username and password, but not sure how to hook that from the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- For
reconfigure
, yes, now that it's rebased, I think this will "just work"! - For translations, you'll just need to edit
en.json
and add new entries for
"data": {
"url": "URL",
"username": "Username (optional)",
"password": "Password (optional)",
}
... then to test, when you restart HA with this, you should see it show those strings next to those fields. Don't worry about other languages, unless you happen to speak them ;-)
Thanks @loispostula ! |
Was this based on my #753 |
Fix #697