Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Publish from GitHub CI #1760

Merged
merged 14 commits into from
Aug 18, 2024
Merged

ci: Publish from GitHub CI #1760

merged 14 commits into from
Aug 18, 2024

Conversation

Gustl22
Copy link
Collaborator

@Gustl22 Gustl22 commented Feb 24, 2024

Description

This allows publishing audioplayers from the GitHub CI.
The PR creation is available as a workflow dispatch (with option for prerelease) to not overwhelm the PR pipeline.

See: dart-lang/pub-dev#7177

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, refactor:,
    docs:, chore:, test:, ci: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation and added dartdoc comments with ///, where necessary.
  • I have updated/added relevant examples in example.

Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Related Issues

@Gustl22

This comment was marked as outdated.

@Gustl22 Gustl22 marked this pull request as ready for review February 24, 2024 18:48
Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't work yet unfortunately, it's blocked by dart-lang/pub-dev#7177 which is solved in dart-lang/pub-dev#7462, but it seems like it will take a while to get that landed.

@Gustl22
Copy link
Collaborator Author

Gustl22 commented Feb 25, 2024

uh oh, thank you for the explanation! And thank you for investing time in such a useful feature. Gave my thumbs for issue and PR :D

@Gustl22
Copy link
Collaborator Author

Gustl22 commented Aug 11, 2024

@Gustl22 Gustl22 requested a review from spydon August 11, 2024 12:58
Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this works yet, I haven't had time to finalize the Melos action (I will get to that after Flutter & Friends), but we can try 😄

@Gustl22
Copy link
Collaborator Author

Gustl22 commented Aug 11, 2024

No hurry, I will give it a try in my own package :D

@Gustl22 Gustl22 enabled auto-merge (squash) August 18, 2024 09:38
@Gustl22 Gustl22 merged commit af6da24 into main Aug 18, 2024
9 checks passed
@Gustl22 Gustl22 deleted the melos-release branch August 18, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants