FIX: Handle NonSupportedFeature exception for pipes #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ersions less than 9. Since we don't support pipes yet anyway, we should handle this exception and move on.
…l because of something in pytango so type checking needs to ignore it.
|
@coretl It looks like CI is failing here due to type checking error in: /home/runner/work/ophyd-async/ophyd-async/src/ophyd_async/core/_table.py:49:80 |
coretl
approved these changes
Nov 22, 2024
Thanks Tom. It looks like this brings down the coverage though. Since this relies on interacting with an old version of Tango, I am not sure how I could write a test for it. |
I don't think I care about this, it's such a small change, I'll merge as is... |
evalott100
pushed a commit
that referenced
this pull request
Nov 27, 2024
* Old tango servers don't support the pipe API when used with PyTango versions less than 9. Since we don't support pipes yet anyway, we should handle this exception and move on. * Fixed linting. NonSupportedFeature is not a recognizable import symbol because of something in pytango so type checking needs to ignore it. * Trigger CI/CD pipeline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old tango servers running tango version less than 9 don't support the pipe API or get_pipe_list(). Since we don't support pipes yet anyway, we should handle this exception and move on.