Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: Handle NonSupportedFeature exception for pipes #660

Merged
merged 3 commits into from
Nov 22, 2024
Merged

FIX: Handle NonSupportedFeature exception for pipes #660

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6ffc8fc
Old tango servers don't support the pipe API when used with PyTango v…
burkeds Nov 21, 2024
0d8c085
Fixed linting. NonSupportedFeature is not a recognizable import symbo…
burkeds Nov 21, 2024
ce38869
Trigger CI/CD pipeline
burkeds Nov 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions src/ophyd_async/tango/signal/_signal.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,14 @@
SignalW,
SignalX,
)
from tango import AttrDataFormat, AttrWriteType, CmdArgType, DeviceProxy, DevState
from tango import (
AttrDataFormat,
AttrWriteType,
CmdArgType,
DeviceProxy,
DevState,
NonSupportedFeature, # type: ignore
)
from tango.asyncio import DeviceProxy as AsyncDeviceProxy

from ._tango_transport import TangoSignalBackend, get_python_type
Expand Down Expand Up @@ -174,8 +181,11 @@ async def infer_signal_type(
else:
dev_proxy = proxy

if tr_name in dev_proxy.get_pipe_list():
raise NotImplementedError("Pipes are not supported")
try:
if tr_name in dev_proxy.get_pipe_list():
raise NotImplementedError("Pipes are not supported")
except NonSupportedFeature: # type: ignore
pass

if tr_name not in dev_proxy.get_attribute_list():
if tr_name not in dev_proxy.get_command_list():
Expand Down