-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API inconsistency and payload props naming #164
Labels
Comments
RobinTail
added
refactoring
Better implementation of the same thing
breaking
Breaking changes
labels
Aug 9, 2023
|
There is also a chance to align payload props, having "active", "status", "result" and other inconsistent naming for relay states. |
Another issue is that some API errors responses have status code 200. |
RobinTail
changed the title
API inconsistency
API inconsistency and payload props naming
Oct 15, 2023
RobinTail
added
enhancement
New feature or request
and removed
breaking
Breaking changes
labels
Oct 17, 2023
This was referenced Oct 21, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
This is actually not a pin, it's a relay index (
r1..r8
).OctoRelay/octoprint_octorelay/__init__.py
Lines 84 to 85 in fc54cf0
It should be renamed.
In order to do this without breaking changes, we should support backward compatibility somehow.
The text was updated successfully, but these errors were encountered: