🚀 3.14.0 #239
Merged
🚀 3.14.0 #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Generating CSS from SASS. * Splitting the sources. * Making style comment removable. * Upgrading all dependencies.
RobinTail
added
refactoring
* Drop Python 3.7 (EOL). * Type constraints for the list of Tasks. * Add mypy config. * Using MyPy in CI. * Revert "Drop Python 3.7 (EOL)." This reverts commit bee43c7. * Add final line to mypy config. * Ignore missing types of flask. * Draft for Model type. * Introducing the correctly typed initial state for the model. * Add final newline. * Listing the dependency on typing-extensions. * Ensure presence of polling timer before cancelling it in on_shutdown method. * Disabing pylint public methods limit for model. * Ref: naming. * Ref: exposing final Model type and get_initial_model() helper for whole one. * Minor: encoding header. * Ref: type constraints in update_ui for upcoming tasks. * Type constraints for get_upcoming_tasks() method. * Ref: improving types for get_upcoming_tasks() argument subjects. * Run type checking before linting. * Minor: excluding snapshots from coverage reporting. * Update octoprint_octorelay/model.py
* Moving response preparation outta handlers. * Making handle_cancel_task_command to return bool. * Adjusting the tests. * Updating tests descriptions. * Testing the faulty case. * Introducing class HandlingException for using in API handlers. * Restoring original behavior to deprecate. * Ref: moving UI update outta try block. * Fix: invalid relay index should also be 400 and have deprecated response. * Moving the disabled relay get status handling into on_api_command method. * Update octoprint_octorelay/__init__.py * Update tests/test_init.py * Apply suggestions from code review * Update tests/test_init.py
|
🚀 3.14.0rc1 |
|
✅ Regression test passed |
* Moving required params checking into the on_api_command() method. * DNRY: reducing complexity.
* Introducing version | v parameter. * Consistent arguments of API v2. * Fix linting issues. * Changed response for cancelTask command in v2. * getStatus command response remains. * Fixing mypy issues. * Changing response for update command of v2. * Changing the response for listAllStatus command of v2. * Fix linting issue. * Partial revert: keeping id naming. * Minor: readability. * Ref: readbility for getStatus command branching. * Update octoprint_octorelay/__init__.py * Ref: Ensure int for version * Ref: todo for subject parameter name for next major release * Type constraints for listing command. * Fix linting issue. * UI: Switching to API v2.
|
🚀 3.14.0rc2 |
|
✅ Regression test passed |
|
|
|
✅ legacy API tests passed |
RobinTail
commented
Oct 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #164
mypyfor type constraints #216