Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ref: Moving required params checks #241

Merged
merged 2 commits into from
Oct 22, 2023
Merged

Ref: Moving required params checks #241

merged 2 commits into from
Oct 22, 2023

Conversation

RobinTail
Copy link
Collaborator

Contributes to #164

@RobinTail RobinTail added the refactoring Better implementation of the same thing label Oct 22, 2023
@RobinTail RobinTail changed the base branch from master to develop October 22, 2023 09:09
@coveralls
Copy link

Coverage Status

coverage: 100.0%. remained the same when pulling fdc1f21 on issue-164-required-params into fd3ef56 on develop.

@RobinTail RobinTail linked an issue Oct 22, 2023 that may be closed by this pull request
API inconsistency and payload props naming #164
Closed
@RobinTail RobinTail marked this pull request as ready for review October 22, 2023 09:29
RobinTail
RobinTail commented Oct 22, 2023
View reviewed changes
Copy link
Collaborator Author

@RobinTail RobinTail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@RobinTail RobinTail merged commit ec6c0f7 into develop Oct 22, 2023
22 checks passed
@RobinTail RobinTail mentioned this pull request Oct 22, 2023
Merged
RobinTail added a commit that referenced this pull request Oct 22, 2023
@RobinTail
🚀 3.14.0, #239
e512dd4 
* Generating CSS from SCSS. (#231)
* Using `mypy` for type constraints (#216)
* Ref: API: Moving response shaping out of handlers (#240)
* Ref: Moving required params checks (#241)
* Feat: API v2 (#242)
* UI: Switching to API v2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
refactoring Better implementation of the same thing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

API inconsistency and payload props naming
2 participants
@RobinTail @coveralls