Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

december-additions-fixes #19

Merged
merged 3 commits into from
Dec 7, 2023
Merged

december-additions-fixes #19

merged 3 commits into from
Dec 7, 2023

Conversation

lukaslevert
Copy link
Collaborator

  • Adds cost model definitions (CPM, CPC, etc.)
  • Adds status indicator section & definitions
  • Shortens title for Reporting and Targeting sections for clarity
  • Replaces "10-second visit" with "Site visit" and expands definition

Copy link

github-actions bot commented Dec 6, 2023

The following commits were not verified:
f986a4c (unsigned)

docs/account-management/billing.md Outdated Show resolved Hide resolved
docs/campaign-performance/status.md Show resolved Hide resolved
Co-authored-by: Ian Krieger <48930920+IanKrieger@users.noreply.github.com>
Copy link
Member

@IanKrieger IanKrieger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since I'm not sure why one commit is unsigned, and the creator of the PR is a Brave employee I am going to forgo requesting a formal security review on this PR.

@lukaslevert lukaslevert added this pull request to the merge queue Dec 7, 2023
Merged via the queue into main with commit 0d1760d Dec 7, 2023
4 checks passed
@lukaslevert lukaslevert deleted the december-additions-fixes branch December 7, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants