Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve an issue with automatic flag for timezone #26210

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

deeppandya
Copy link
Contributor

@deeppandya deeppandya commented Oct 24, 2024

Resolves brave/brave-browser#41869

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Select Mountain time as the timezone in the device
  2. Buy VPN subscription
  3. Create VPN profile and start the connection
  4. observe that the selected server should be Denver as it's the only server in mountain timezone
  5. try changing the server from the list and observe the change in the server
  6. Select automatic and observe that vpn tunnel should be connected to Denver

@deeppandya deeppandya added CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64 CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-teamcity Do not run builds in TeamCity labels Oct 24, 2024
@deeppandya deeppandya added this to the 1.73.x - Nightly milestone Oct 24, 2024
@deeppandya deeppandya self-assigned this Oct 24, 2024
Copy link
Contributor

@samartnik samartnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@deeppandya deeppandya force-pushed the update_automatic_flag_behaviour_vpn branch from 84ed584 to 446a2ae Compare October 25, 2024 16:05
@deeppandya deeppandya merged commit 3373071 into master Oct 25, 2024
17 checks passed
@deeppandya deeppandya deleted the update_automatic_flag_behaviour_vpn branch October 25, 2024 17:49
brave-builds added a commit that referenced this pull request Oct 25, 2024
brave-builds added a commit that referenced this pull request Oct 25, 2024
@brave-builds
Copy link
Collaborator

Released in v1.73.50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-teamcity Do not run builds in TeamCity CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update automatic selection of the server for VPN
3 participants