Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Fix crash when dismissing news opt-in on NTP #26228

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

StephenHeaps
Copy link
Collaborator

@StephenHeaps StephenHeaps commented Oct 25, 2024

  • Fix crash on iOS 18+ by not dequeueing a cell when scrolling to top after dismissing news card
  • Fix layout bug causing empty scroll space on new tab page after dismissing news card

Resolves brave/brave-browser#41858

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Fresh install app on iOS 18+.
  2. On New Tab Page, tap 'X' on news opt-in card.
  3. Verify app does not crash.
  4. Scroll down, verify no empty space where news card used to be.

@StephenHeaps StephenHeaps added CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 CI/skip-macos-arm64 Do not run CI builds for macOS arm64 labels Oct 25, 2024
@StephenHeaps StephenHeaps self-assigned this Oct 25, 2024
@StephenHeaps StephenHeaps requested a review from a team as a code owner October 25, 2024 15:47
@StephenHeaps StephenHeaps enabled auto-merge (squash) October 25, 2024 15:53
brave-builds added a commit that referenced this pull request Oct 25, 2024
brave-builds added a commit that referenced this pull request Oct 25, 2024
@StephenHeaps StephenHeaps merged commit e83e96e into master Oct 25, 2024
18 checks passed
@StephenHeaps StephenHeaps deleted the bugfix/dismiss-news-opt-in-crash branch October 25, 2024 17:08
@github-actions github-actions bot added this to the 1.73.x - Nightly milestone Oct 25, 2024
kjozwiak pushed a commit that referenced this pull request Oct 25, 2024
@brave-builds
Copy link
Collaborator

Released in v1.73.50

kjozwiak pushed a commit that referenced this pull request Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Browser crash when closing News opt-in message on new tab
3 participants