Add an option to produce a textfile trace of instructions executed #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #39 +/- ##
==========================================
- Coverage 27.40% 27.31% -0.10%
==========================================
Files 42 44 +2
Lines 9014 9055 +41
==========================================
+ Hits 2470 2473 +3
- Misses 6544 6582 +38 ☔ View full report in Codecov by Sentry. |
|
I wanted to avoid a |
ava-silver
reviewed
Dec 29, 2023
| fn handle(&mut self, trace: &CpuTrace) { | ||
| self | ||
| .file | ||
| .write_all(format!("{:04X}: {:02X}\n", trace.address, trace.opcode).as_bytes()) |
There was a problem hiding this comment.
could be good to make this buffered with BufWriter, i'm happy to implement that
ava-silver
previously approved these changes
Dec 29, 2023
ava-silver
dismissed
their stale review
waiting until we add support for buffering
|
Rebased on top of main to include changes from #40 |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Useful for debugging.
Adds infrastructure as well in case we want to make the trace more detailed in the future, make other kinds of trace handlers, etc.