-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Cpu
and System
traits
#40
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Ava Silver <ava@avasilver.dev>
Co-authored-by: Ava Silver <ava@avasilver.dev>
Co-authored-by: Ava Silver <ava@avasilver.dev>
Co-authored-by: Ava Silver <ava@avasilver.dev>
Co-authored-by: Ava Silver <ava@avasilver.dev>
Co-authored-by: Ava Silver <ava@avasilver.dev>
ava-silver
approved these changes
Dec 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! good refactor
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #40 +/- ##
==========================================
- Coverage 27.49% 27.40% -0.10%
==========================================
Files 41 42 +1
Lines 8988 9014 +26
==========================================
- Hits 2471 2470 -1
- Misses 6517 6544 +27 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cpu
trait from theMos6502
struct to prepare for supporting other CPUs (Z80, etc)SystemInfo
struct (previously only used to store the number of clock ticks) and standardize on usingu64
for clock cycle countsWhateverBuilder
unit structs, refactor theSystemBuilder
trait into aBuildableSystem
trait which is implemented for the system itselfget_cpu
method to the System trait to allow for provided implementations to be added to System (e.g., upcoming work in trace generation in Add an option to produce a textfile trace of instructions executed #39)