Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fold80 Bug Fix #1972

Draft
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

Patrick-Schlaeger-Broad

Description

Added highQualityDepthHistogramNonZero as a histogram variable to WgsMetrics.java and CollectTargetMetrics.java.highQualityDepthHistogramNonZero is identical to highQualityDepthHistogram, but gets rid of its '0 coverage' bin. highQualityDepthHistogramNonZero is then used in the place of the highQualityDepthHistogram for the calculation of the FOLD_80_BASE_PENALTY metric. The motivation for making this change is to have these metrics accurately calculate the FOLD_80_BASE_PENALTY metric accord to its definition: "The fold over-coverage necessary to raise 80% of bases in "non-zero-cvg" targets to the mean coverage level in those targets."

This change fixes the issue brought up in the following Picard Bug Report.


Checklist (never delete this)

Never delete this, it is our record that procedure was followed. If you find that for whatever reason one of the checklist points doesn't apply to your PR, you can leave it unchecked but please add an explanation below.

Content

  • Added or modified tests to cover changes and any new functionality
  • Edited the README / documentation (if applicable)
  • All tests passing on github actions

Review

  • Final thumbs-up from reviewer
  • Rebase, squash and reword as applicable

For more detailed guidelines, see https://github.com/broadinstitute/picard/wiki/Guidelines-for-pull-requests

@Patrick-Schlaeger-Broad Patrick-Schlaeger-Broad marked this pull request as draft July 31, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant