Only extract declared outputs from firecracker workspaces #7959
+274
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bduffany
force-pushed
the
debugfs-optimize
branch
10 times, most recently
from
32da903 to
49c3ba4
Compare
bduffany
changed the title
bduffany
force-pushed
the
debugfs-optimize
branch
3 times, most recently
from
ac87359 to
9266235
Compare
bduffany
requested review from
tylerwilliams,
vadimberezniker,
vanja-p and
maggie-lou
bduffany
force-pushed
the
debugfs-optimize
branch
3 times, most recently
from
9698bec to
1d5a0ad
Compare
bduffany
force-pushed
the
debugfs-optimize
branch
from
1d5a0ad to
d72d17b
Compare
vanja-p
approved these changes
Nov 26, 2024
vadimberezniker
approved these changes
Nov 26, 2024
bduffany
force-pushed
the
debugfs-optimize
branch
from
d72d17b to
a63df3b
Compare
bduffany
commented
Nov 26, 2024
| // TODO: declare this list as a constant somewhere? | ||
| paths := []string{ | ||
| ".BUILDBUDDY_DO_NOT_RECYCLE", | ||
| ".BUILDBUDDY_INVALIDATE_SNAPSHOT", |
There was a problem hiding this comment.
@maggie-lou FYI I preemptively added the new file here from your in-flight PR. After our PRs are both merged I'm thinking of maybe adding a list to container.go with these special file names
bduffany
changed the title
bduffany
added a commit
that referenced
this pull request
Dec 16, 2024
We aren't actively using this code. The `debugfs` codepath is probably "fast enough" since we updated it to only copy output paths in #7959, and also this code is likely to be supplanted by FUSE anyway. If we do want to try this code again in the future, we can always bring it back, but should test thoroughly in dev first because we hit some issues with the loopback device approach last time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should significantly cut down on IO due to extracting lots of files from the guest workspace drive that aren't needed, and also unlinking them afterwards.
Depends on #7957 so that we don't have to guard against path traversals in this new code (since we're passing the user-provided
output_pathsto this new func).