Add support for mlobs sink on logger #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khorshuheng
force-pushed
the
observability-logger
branch
from
79f80fb to
b8f27da
Compare
khorshuheng
force-pushed
the
observability-logger
branch
from
b8f27da to
c6228d0
Compare
6 tasks
khorshuheng
force-pushed
the
observability-logger
branch
3 times, most recently
from
a790b6f to
cd105bc
Compare
khorshuheng
force-pushed
the
observability-logger
branch
from
cd105bc to
79bb457
Compare
ariefrahmansyah
approved these changes
Mar 26, 2024
6 tasks
ariefrahmansyah
pushed a commit
that referenced
this pull request
Mar 27, 2024
<!-- Thanks for sending a pull request! Here are some tips for you: 1. Run unit tests and ensure that they are passing 2. If your change introduces any API changes, make sure to update the e2e tests 3. Make sure documentation is updated for your PR! --> # Description <!-- Briefly describe the motivation for the change. Please include illustrations where appropriate. --> Related to #554 . This MR add a new configuration named MLObsLoggerDestinationUrl. If a model which observability has been enabled is deployed, and logging has been enabled, the logger will send the logs via MLObs sink as opposed to KafkaSink. # Modifications <!-- Summarize the key code changes. --> # Tests <!-- Besides the existing / updated automated tests, what specific scenarios should be tested? Consider the backward compatibility of the changes, whether corner cases are covered, etc. Please describe the tests and check the ones that have been completed. Eg: - [x] Deploying new and existing standard models - [ ] Deploying PyFunc models --> # Checklist - [ ] Added PR label - [ ] Added unit test, integration, and/or e2e tests - [ ] Tested locally - [ ] Updated documentation - [ ] Update Swagger spec if the PR introduce API changes - [ ] Regenerated Golang and Python client if the PR introduces API changes # Release Notes <!-- Does this PR introduce a user-facing change? If no, just write "NONE" in the release-note block below. If yes, a release note is required. Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required". For more information about release notes, see kubernetes' guide here: http://git.k8s.io/community/contributors/guide/release-notes.md --> ```release-note ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This MR update the merlin logger to support writing prediction log instead of inference log to Kafka, via a new type of sink named MLObs sink, which will apply if the log url prefix is "mlobs". Merlin API service itself has not been updated to utilize this new sink. That will be implemented in another PR.
Modifications
Tests
Checklist
Release Notes