-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set verbose = False
as default on all the interfaces
#1153
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall.
Do you think we should propagate verbose from NWBConverter to the datainterfaces (if they aren't already specified in source_data
)? I usually want either all the interfaces verbose or none, but I don't know about other people's usage.
src/neuroconv/datainterfaces/ecephys/baserecordingextractorinterface.py
Outdated
Show resolved
Hide resolved
…erface.py Co-authored-by: Paul Adkisson <paul.wesley.adkisson@gmail.com>
Yes, I think this is a good idea. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1153 +/- ##
=======================================
Coverage 90.69% 90.69%
=======================================
Files 129 129
Lines 8189 8286 +97
=======================================
+ Hits 7427 7515 +88
- Misses 762 771 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
|
We have discussed this many times but never did it.