Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set verbose = False as default on all the interfaces #1153

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

h-mayorquin
Copy link
Collaborator

@h-mayorquin h-mayorquin commented Dec 10, 2024

We have discussed this many times but never did it.

@h-mayorquin h-mayorquin self-assigned this Dec 10, 2024
@h-mayorquin h-mayorquin marked this pull request as ready for review December 10, 2024 22:27
Copy link
Member

@pauladkisson pauladkisson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall.

Do you think we should propagate verbose from NWBConverter to the datainterfaces (if they aren't already specified in source_data)? I usually want either all the interfaces verbose or none, but I don't know about other people's usage.

@h-mayorquin
Copy link
Collaborator Author

Do you think we should propagate verbose from NWBConverter to the datainterfaces (if they aren't already specified in source_data)? I usually want either all the interfaces verbose or none, but I don't know about other people's usage.

Yes, I think this is a good idea.

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.69%. Comparing base (96dfdff) to head (2c3b466).
Report is 12 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1153   +/-   ##
=======================================
  Coverage   90.69%   90.69%           
=======================================
  Files         129      129           
  Lines        8189     8286   +97     
=======================================
+ Hits         7427     7515   +88     
- Misses        762      771    +9     
Flag Coverage Δ
unittests 90.69% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...nv/datainterfaces/behavior/audio/audiointerface.py 88.09% <ø> (ø)
...ces/behavior/deeplabcut/deeplabcutdatainterface.py 93.47% <ø> (ø)
...nterfaces/behavior/fictrac/fictracdatainterface.py 92.30% <ø> (ø)
...s/behavior/lightningpose/lightningposeconverter.py 96.82% <ø> (ø)
...havior/lightningpose/lightningposedatainterface.py 95.37% <ø> (ø)
...atainterfaces/behavior/medpc/medpcdatainterface.py 94.38% <ø> (ø)
...aces/behavior/neuralynx/neuralynx_nvt_interface.py 98.38% <100.00%> (+0.02%) ⬆️
...atainterfaces/behavior/sleap/sleapdatainterface.py 95.65% <ø> (ø)
...aces/ecephys/alphaomega/alphaomegadatainterface.py 100.00% <100.00%> (ø)
...datainterfaces/ecephys/axona/axonadatainterface.py 90.32% <100.00%> (ø)
... and 45 more

... and 4 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants