Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update behavior #8

Merged
merged 7 commits into from
Oct 9, 2024
Merged

Update behavior #8

merged 7 commits into from
Oct 9, 2024

Conversation

pauladkisson
Copy link
Member

This PR adds a trials table with remaining behavioral variables, and switches to pymatreader to accommodate both types of .mat files.

Copy link

@h-mayorquin h-mayorquin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Some minor comments.

Bigger commnent is unrelated to this PR though. After checking the state of the ndx-events 3.0 discussion I would advice to use ndx-events 2.0 which is already released as the former might still change quite a bit.

@pauladkisson
Copy link
Member Author

Bigger commnent is unrelated to this PR though. After checking the state of the ndx-events 3.0 discussion I would advice to use ndx-events 2.0 which is already released as the former might still change quite a bit.

Moving this to #11 for discussion.

@pauladkisson pauladkisson merged commit 6f5f329 into main Oct 9, 2024
1 check failed
@pauladkisson pauladkisson deleted the update_behavior branch October 9, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants