This repository has been archived by the owner on Jun 2, 2024. It is now read-only.
docs(README): hardcode version in more places #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As we make use of release-please, I feel like it's nicer to hardcode the versions as they will automatically get updated upon release.
uncenter
reviewed
May 27, 2024
| @@ -103,7 +103,7 @@ sudo flatpak override --env=GTK_THEME="catppuccin-${FLAVOR}-${ACCENT}-standard+d | |||
|
|
|||
| ### Manual installation | |||
|
|
|||
| If your distro does not package our theme, and the installation script will not work for your use case, you can pull down releases and extract them yourself. You can find the [latest release on GitHub](https://github.com/catppuccin/gtk/releases/latest). | |||
There was a problem hiding this comment.
Hmm the first change is good since there could be unreleased commits on main, but the existing link here already goes to the latest release?
There was a problem hiding this comment.
Well the idea is that the tag would be the latest release, no? I feel like it's nicer to be explicit and it doesn't come with any extra cost
There was a problem hiding this comment.
The benefit is that you'd be able to go into commit history and actually have the latest release link point to the latest release at that point in time. I think it's nice 🤔
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we make use of release-please, I feel like it's
nicer to hardcode the versions as they will
automatically get updated upon release.