Skip to content
This repository has been archived by the owner on Jun 2, 2024. It is now read-only.

docs(README): hardcode version in more places #256

Merged
merged 1 commit into from
May 27, 2024
Merged

docs(README): hardcode version in more places #256

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ We provide a Python script to automate the process of installing the theme:
<!-- x-release-please-start-version -->

```bash
curl -LsS "https://raw.githubusercontent.com/catppuccin/gtk/main/install.py" -o install.py
curl -LsSO "https://raw.githubusercontent.com/catppuccin/gtk/v1.0.2/install.py"
python3 install.py <flavor> <accent>
[catppuccin-gtk] [INFO] - Installation info:
flavor: mocha
Expand Down Expand Up @@ -103,7 +103,7 @@ sudo flatpak override --env=GTK_THEME="catppuccin-${FLAVOR}-${ACCENT}-standard+d

### Manual installation

If your distro does not package our theme, and the installation script will not work for your use case, you can pull down releases and extract them yourself. You can find the [latest release on GitHub](https://github.com/catppuccin/gtk/releases/latest).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm the first change is good since there could be unreleased commits on main, but the existing link here already goes to the latest release?

Copy link
Contributor Author

@sgoudham sgoudham May 27, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well the idea is that the tag would be the latest release, no? I feel like it's nicer to be explicit and it doesn't come with any extra cost

Copy link
Contributor Author

@sgoudham sgoudham May 27, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The benefit is that you'd be able to go into commit history and actually have the latest release link point to the latest release at that point in time. I think it's nice 🤔

If your distro does not package our theme, and the installation script will not work for your use case, you can pull down releases and extract them yourself. You can find the [latest release on GitHub](https://github.com/catppuccin/gtk/releases/tag/v1.0.2).

```bash
cd ~/.local/share/themes
Expand Down