Imageset slicing #634
Merged
Imageset slicing #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rroneous behaviour introduced by including batch offsets in imagesequence slicing. The ImageSequence class provides access to images using a 0-based array index, no matter what the array_range is set to!
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #634 +/- ##
==========================================
- Coverage 39.39% 39.09% -0.30%
==========================================
Files 178 179 +1
Lines 15519 15745 +226
Branches 2996 3037 +41
==========================================
+ Hits 6113 6155 +42
- Misses 8827 9010 +183
- Partials 579 580 +1 |
This was referenced Jul 28, 2023
This was referenced Oct 17, 2023
ndevenish
added a commit
to ndevenish/dxtbx
that referenced
this pull request
Apr 23, 2024
The underlying issue was fixed in cctbx#634.
ndevenish
added a commit
that referenced
this pull request
Apr 23, 2024
The underlying issue was fixed in #634.
toastisme
pushed a commit
to toastisme/dxtbx
that referenced
this pull request
Jul 18, 2024
The underlying issue was fixed in cctbx#634.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first of two PRs to fix imageset slicing (#633). A DIALS PR will follow.