Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Imageset slicing #634

Merged
merged 7 commits into from
Jul 26, 2023
Merged

Imageset slicing #634

merged 7 commits into from
Jul 26, 2023

Commits on May 4, 2023

  1. What happens if we remove the batch offset stuff from imageset slicing?

    @dagewa
    dagewa committed May 4, 2023
    Configuration menu
    Copy the full SHA
    eccc2ea View commit details
    Browse the repository at this point in the history

Commits on May 5, 2023

  1. The workaround in cctbx#485 for negative offset was reacting to the e… 

    …rroneous

behaviour introduced by including batch offsets in imagesequence slicing.
The ImageSequence class provides access to images using a 0-based array
index, no matter what the array_range is set to!
    @dagewa
    dagewa committed May 5, 2023
    Configuration menu
    Copy the full SHA
    8ad4f0e View commit details
    Browse the repository at this point in the history

  2. Add a test that shows that data access is as expected after slicing

    @dagewa
    dagewa committed May 5, 2023
    Configuration menu
    Copy the full SHA
    78e63ee View commit details
    Browse the repository at this point in the history

  3. We do not slice using the "array_range"!

    @dagewa
    dagewa committed May 5, 2023
    Configuration menu
    Copy the full SHA
    d9efffc View commit details
    Browse the repository at this point in the history

  4. News

    @dagewa
    dagewa committed May 5, 2023
    Configuration menu
    Copy the full SHA
    6efa805 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2023

  1. Merge branch 'main' into 633-imageset-slicing

    @dagewa
    dagewa committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    da0926e View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2023

  1. Update 633.bugfix

    @ndevenish
    ndevenish authored Jul 26, 2023
    Configuration menu
    Copy the full SHA
    5b8afaf View commit details
    Browse the repository at this point in the history