Update staking-governance-supply.md #1748
Conversation
Clarifying unlock dates
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (1)
learn/staking-governance-supply.md (1)
104-105: Excellent addition for clarity on unlock datesThis note provides valuable clarification on the exact dates for yearly unlocks, taking into account the leap year in 2024. It helps prevent any potential confusion about the precise timing of unlock events.
A minor suggestion to enhance readability:
-_Note: Due to 2024 being a leap year, the yearly unlock intervals will occur on October 30th of each year. For example, unlocks at year 1 will occur on October 30, 2024._ +_Note: Due to 2024 being a leap year, the yearly unlock intervals will occur on October 30th of each year. For example, the first yearly unlock (year 1) will occur on October 30, 2024._This small change makes it clearer that October 30, 2024, is specifically the date for the first yearly unlock.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- learn/staking-governance-supply.md (1 hunks)
🔇 Additional comments (1)
learn/staking-governance-supply.md (1)
Line range hint
1-105: Overall document review: Approved with suggestionsThe document provides a comprehensive and well-structured overview of staking, governance, and supply for the Celestia blockchain. The added note about unlock dates significantly improves clarity. If the suggested updates regarding specific dates in the unlock schedules are implemented, the document will offer even more precise and consistent information to readers.
Great job on maintaining and improving this crucial documentation!
| _Note: Due to 2024 being a leap year, the yearly unlock intervals will occur on October 30th of each year. For example, unlocks at year 1 will occur on October 30, 2024._ | ||
|
|
There was a problem hiding this comment.
🛠️ Refactor suggestion
Consider updating unlock schedules with specific dates
The added note provides excellent clarity on the yearly unlock dates. To maintain consistency throughout the document, consider updating the unlock schedule table and the "Unlocks" section with these specific dates. This would provide readers with a clear and consistent understanding of when unlocks occur across all sections of the document.
For example, in the unlock schedule table, you could update entries like this:
- 33.33% unlocked at year 1.<br/>Remaining 66.67% unlocks continuously from year 1 to year 2.
+ 33.33% unlocked on October 30, 2024.<br/>Remaining 66.67% unlocks continuously from October 30, 2024 to October 30, 2025.This level of detail would align with the newly added note and provide readers with precise information throughout the document.
Committable suggestion was skipped due to low confidence.
|
Congrats, your important contribution to this open-source project has earned you a GitPOAP! GitPOAP: 2024 Celestia Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
Clarifying unlock dates