Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update staking-governance-supply.md #1748

Merged
merged 2 commits into from
Oct 14, 2024
Merged

Update staking-governance-supply.md #1748

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
de6142c
Update staking-governance-supply.md
nwhite1 Oct 2, 2024
942a4aa
Merge branch 'celestiaorg:main' into main
nwhite1 Oct 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions learn/staking-governance-supply.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,8 @@ _The definitions for circulating and available supply were adapted from

Unlock schedule by category is described in the table below.

_Note: Due to 2024 being a leap year, the yearly unlock intervals will occur on October 30th of each year. For example, unlocks at year 1 will occur on October 30, 2024._

Comment on lines +104 to +105
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Consider updating unlock schedules with specific dates

The added note provides excellent clarity on the yearly unlock dates. To maintain consistency throughout the document, consider updating the unlock schedule table and the "Unlocks" section with these specific dates. This would provide readers with a clear and consistent understanding of when unlocks occur across all sections of the document.

For example, in the unlock schedule table, you could update entries like this:

- 33.33% unlocked at year 1.<br/>Remaining 66.67% unlocks continuously from year 1 to year 2.
+ 33.33% unlocked on October 30, 2024.<br/>Remaining 66.67% unlocks continuously from October 30, 2024 to October 30, 2025.

This level of detail would align with the newly added note and provide readers with precise information throughout the document.

Committable suggestion was skipped due to low confidence.

| Category | Unlock Schedule |
|---------------------------|---------------------------------------------------------------------------------------------|
| Public Allocation | Fully unlocked at launch. |
Expand Down
Loading