dry_run always returns OK() #4124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removed auction check when reediming
kylezs
reviewed
Oct 16, 2023
api/lib/src/lib.rs
Outdated
| @@ -150,11 +150,12 @@ impl< | |||
| call: RuntimeCall, | |||
| at: Option<state_chain_runtime::Hash>, | |||
| ) -> Result<Bytes> { | |||
| Ok(self | |||
| let _ = self | |||
There was a problem hiding this comment.
We can just delete the old code
(whoever does the real fix can either look at this PR to see what was removed, or, because they'll be on main, they'll already have it)
Codecov Report
@@ Coverage Diff @@
## release/0.10 #4124 +/- ##
============================================
Coverage 72% 72%
============================================
Files 372 372
Lines 59360 59353 -7
Branches 59360 59353 -7
============================================
+ Hits 42665 42676 +11
+ Misses 14571 14558 -13
+ Partials 2124 2119 -5
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
kylezs
approved these changes
Oct 16, 2023
|
Cheers |
dandanlen
reviewed
Oct 17, 2023
| @@ -147,14 +146,10 @@ impl< | |||
| { | |||
| async fn dry_run( | |||
| &self, | |||
| call: RuntimeCall, | |||
| at: Option<state_chain_runtime::Hash>, | |||
| _call: RuntimeCall, | |||
There was a problem hiding this comment.
Can we add a todo or comment here (referencing the Linear issue)?
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Related: PRO-917
Checklist
Please conduct a thorough self-review before opening the PR.
Summary