fix: bouncer btc client mutex for vault swaps #5436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5436 +/- ##
======================================
- Coverage 72% 72% -0%
======================================
Files 490 490
Lines 87053 86929 -124
Branches 87053 86929 -124
======================================
- Hits 62423 62234 -189
- Misses 21675 21731 +56
- Partials 2955 2964 +9 ☔ View full report in Codecov by Sentry. |
kylezs
reviewed
Nov 21, 2024
dandanlen
reviewed
Nov 21, 2024
j4m1ef0rd
changed the title
j4m1ef0rd
force-pushed
the
fix/bouncer-utxo-selection
branch
from
1714311 to
59cf85a
Compare
|
I was playing around with this on Friday, and it looks like the Bitcoin nodes have a This would also solve the (still remaining) issue that we can only select a single utxo. I'll see if it works on localnet and if yes, will push it. |
dandanlen
approved these changes
Nov 25, 2024
dandanlen
reviewed
Nov 25, 2024
- lockUnspents: true to ensure we don't try to double-spend - changePosition: 2 on vault swaps to ensure a valid transaction
kylezs
approved these changes
Nov 26, 2024
nmammeri
pushed a commit
that referenced
this pull request
Nov 27, 2024
* fix: bouncer lock utxos after selection * refactor: use mutex instead of locking * feat: use bitcoin node's input selection. * chore: set correct timeouts for LP-API bouncer test * fix: additional btc tx options: - lockUnspents: true to ensure we don't try to double-spend - changePosition: 2 on vault swaps to ensure a valid transaction --------- Co-authored-by: Daniel <daniel@chainflip.io>
nmammeri
pushed a commit
that referenced
this pull request
Nov 27, 2024
* fix: bouncer lock utxos after selection * refactor: use mutex instead of locking * feat: use bitcoin node's input selection. * chore: set correct timeouts for LP-API bouncer test * fix: additional btc tx options: - lockUnspents: true to ensure we don't try to double-spend - changePosition: 2 on vault swaps to ensure a valid transaction --------- Co-authored-by: Daniel <daniel@chainflip.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Closes: PRO-1832
Checklist
Please conduct a thorough self-review before opening the PR.
Summary
Using the btc client mutex around selecting inputs and sending transaction to avoid double spending error.