feature/user_signup_6

[lohit97]

No description provided.

[championswimmer]

1 more change requested, apart from that, can we also add a test for the code that was added?

should test

• adding users
• adding 2 users with same email and the error that happens
• sending unparseable json in the request body

there is an example test in the test folder, can just expand on that.

[lohit97]

@championswimmer Locally also I replicated the timeout error from tests. I increased the timeout duration to 1.5 seconds and the tests passed with duration of 1.1 seconds. Is there something wrong with the way DB ops are being done or is it just that test file DB (in-memory) I/O is causing some issue?

[lohit97]

0903309

The tests seem to be passing on GH Actions (on the forked repo) also now within the timeout duration. Not sure. Too tight timeout duration?
https://github.com/lohit97/onepixel_backend/actions/runs/6829950274

[championswimmer]

0903309

The tests seem to be passing on GH Actions (on the forked repo) also now within the timeout duration. Not sure. Too tight timeout duration? lohit97/onepixel_backend/actions/runs/6829950274

We can increase the timeout a bit if we want to, sure.

[codecov]

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

[lohit97]

Added a couple of tests to increase coverage. A few more tests can be added to increase but that will require mocking the DB. @championswimmer Do we need that? Although, I think coverage criteria should pass without that.