Incorrect customer attribute returned by Ruby Gem [ch21317] (#85)

.gitignore

@@ -9,3 +9,4 @@
 /tmp/
 *.swp
 vendor/bundle
+/.idea

lib/chartmogul/utils/json_parser.rb

@@ -20,7 +20,15 @@ def typecast_custom_attributes(custom_attributes)
         def opt_string_to_time(value)
           return value unless value.instance_of?(String)
 
-          Time.iso8601(value) rescue Time.rfc2822(value) rescue value
+          parse_timestamp(value)
+        rescue ArgumentError
+          value
+        end
+
+        def parse_timestamp(value)
+          Time.iso8601(value)
+        rescue ArgumentError
+          Time.rfc2822(value)
         end
       end
     end

lib/chartmogul/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module ChartMogul
-  VERSION = '1.6.5'
+  VERSION = '1.6.6'
 end

spec/chartmogul/utils/json_parser_spec.rb

@@ -14,9 +14,14 @@
       expect(result[:attr]).to be_instance_of(Time)
     end
 
-    it "doesn't parse string vaguely looking like a date" do
+    it 'doesn\'t parse string vaguely looking like a date' do
       result = described_class.typecast_custom_attributes(attr: 'May the force be with you.')
       expect(result[:attr]).to be_instance_of(String)
     end
+
+    it 'return string if parse of timestamp failed' do
+      result = described_class.typecast_custom_attributes(attr: '2016-02-01T0000:00.000Z')
+      expect(result[:attr]).to be_instance_of(String)
+    end
   end
 end