-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Mac build, update GHA build to take into account latest Surelog compatibility changes, remove conda #485
base: main
Are you sure you want to change the base?
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
fea0d17
to
b48b19d
Compare
run: | | ||
sudo apt-get update | ||
sudo apt-get install git g++-9 build-essential bison flex \ | ||
libreadline-dev gawk tcl-dev libffi-dev git graphviz xdot \ | ||
pkg-config libboost-system-dev libboost-python-dev \ | ||
libboost-filesystem-dev zlib1g-dev clang-format-8 cmake | ||
libboost-filesystem-dev zlib1g-dev clang-format-8 cmake \ | ||
nlohmann-json3-dev iverilog |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aren't there googletest dependencies available in Ubuntu and homebrew that we can use directly from the package manager ?
That way we don't need the separate googletest compilation step below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if they compile to support c++ 17 string views which are needed, I can test though
I think removing the gtest from third_party and then use what is on the system is a good improvement that can be done in a smallish, separate PR and reduces the size of this one. |
Should the workflow be run ? |
sorry will be getting back to this shortly, been a busy couple months 😢 |
2410266
to
d849f50
Compare
This PR is ready, please do NOT enable the workflows yet as there appears to be a new (~1-2 days ago) issue with homebrew ccache that I want to resolve on my fork before making extra noise for everyone. Given the size of this PR, even though the complexity is quite low, I've started breaking changes out into other PRs:
There are a few major follow-on issues to investigate:
|
aa64f67
to
7ed60fe
Compare
Everything except the linux ql-qlf plugin is working and passing all tests. I believe this is due to little differences is path handling, I hit a bunch of those for e.g. how icarus deals with include paths, etc. All conda reliance is completely removed. |
rename synth_quicklogic to synth_quicklogic_f4pga to not conflict with yosys internal update gha to just use vendored surelog deps build and install flatbuffers install orderedmultidict for surelog fix surelog build on mac Add test assets to gitignore add specific version of surelog
Opening this for visibility, please don't "Approve and Run" the CI as I will continue to be noisy. I am testing actions on my fork.
-D
switch in BSDinstall
#74synth_quicklogic
tosynth_quicklogic_f4pga
(fixes synth_quicklogic name conflict #496)json11
tonlohmann-json
(nlohmann-json
also used by Surelog as of Issue#3812#3818 Introducing json, and cache working directories for sepcmd Surelog#3827, so this is a good alignment)This PR has been validated locally against a non-conda Surelog / UHDM and source-installed Yosys on MacOS 13, but is still very much a work-in-progress as I work through lots of CI changes
xref / supercedes: #445
xref: #431
xref: #432
xref: #365