Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Fix" flaky tests #749

Merged
merged 2 commits into from
Sep 26, 2024
Merged

"Fix" flaky tests #749

merged 2 commits into from
Sep 26, 2024

Conversation

mikemhenry
Copy link
Contributor

We had a test that seg faults on osx sometimes and a test that always fails on windows, this PR keeps CI green

@codecov Codecov
Copy link

codecov bot commented Sep 25, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.95%. Comparing base (b74a61a) to head (8729009).
Report is 1 commits behind head on main.

Additional details and impacted files

ijpulidos
ijpulidos approved these changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@ijpulidos ijpulidos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! We want this :) LGTM!

@ijpulidos ijpulidos merged commit c2a13c0 into main Sep 26, 2024
28 checks passed
@ijpulidos ijpulidos deleted the fix/flaky-tests branch September 26, 2024 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ijpulidos ijpulidos ijpulidos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikemhenry @ijpulidos