Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Fix" flaky tests #749

Merged
merged 2 commits into from
Sep 26, 2024
Merged

"Fix" flaky tests #749

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
afece0e
Re-run test since it fails somtimes on osx with a segfault
mikemhenry Sep 25, 2024
8729009
skip test that fails on windows
mikemhenry Sep 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions openmmtools/tests/test_sampling.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,6 +310,9 @@ def test_with_unsampled_states(self):
"""Test multistate sampler on a harmonic oscillator with unsampled endstates"""
self.run(include_unsampled_states=True)

# on windows we get a ZeroDivisionError: float division by zero
# when measuring the timing data
@pytest.mark.skipif(sys.platform.startswith("win"), reason="Test fails on windows")
def test_without_unsampled_states(self):
"""Test multistate sampler on a harmonic oscillator without unsampled endstates"""
self.run(include_unsampled_states=False)
Expand Down Expand Up @@ -1858,6 +1861,7 @@ def test_analysis_opens_without_checkpoint(self):
del reporter
self.REPORTER(storage_path, checkpoint_storage=cp_file_mod, open_mode="r")

@pytest.mark.flaky(reruns=3)
def test_storage_reporter_and_string(self):
"""Test that creating a MultiState by storage string and reporter is the same"""
thermodynamic_states, sampler_states, unsampled_states = copy.deepcopy(
Expand Down
Loading