Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add back pyciemss logging wrapper to calibrate #444

Merged
merged 1 commit into from
Jan 2, 2024
Merged

Add back pyciemss logging wrapper to calibrate #444

merged 1 commit into from
Jan 2, 2024

Conversation

SamWitty
Copy link
Contributor

@SamWitty SamWitty commented Jan 2, 2024

As discussed in #440 , it appears that the pyciemss_logging_wrapper decorator was previously omitted from the calibrate interface method. This tiny PR adds it back in.

@SamWitty SamWitty added awaiting review PR submitter awaiting code review from reviewer integration Tasks for integration with TA4 labels Jan 2, 2024
@SamWitty SamWitty requested a review from djinnome January 2, 2024 15:19
@SamWitty SamWitty self-assigned this Jan 2, 2024
djinnome
djinnome approved these changes Jan 2, 2024
View reviewed changes
Copy link
Contributor

@djinnome djinnome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@djinnome
Copy link
Contributor

djinnome commented Jan 2, 2024

I do notice that only sample, ensemble_sample, and calibrate.

Do we have an ETA for getting optimize and ensemble_calibrate back into pyCIEMSS?

@djinnome djinnome merged commit 5fa3fde into main Jan 2, 2024
5 checks passed
@djinnome djinnome removed the awaiting review PR submitter awaiting code review from reviewer label Jan 2, 2024
@djinnome djinnome deleted the sw-calibrate-logging branch January 2, 2024 15:36
@SamWitty SamWitty mentioned this pull request Jan 2, 2024
Merged
@SamWitty
Copy link
Contributor Author

SamWitty commented Jan 2, 2024

I do notice that only sample, ensemble_sample, and calibrate.

Do we have an ETA for getting optimize and ensemble_calibrate back into pyCIEMSS?

I'm going to add back ensemble_calibrate now.

@SamWitty SamWitty mentioned this pull request Jan 2, 2024
Closed
fivegrant added a commit to fivegrant/pyciemss that referenced this pull request Jan 3, 2024
@fivegrant @SamWitty
Use refactor fixes early (#1)
2669233 
* Add `ensemble` dir to `setup.cfg`

* Align return type of `calibrate`

* Change "parameters" -> "inferred_parameters"

* added pyciemss logging wrapper to calibrate (ciemss#444)

* Add progress hook (and example usage in test) for `calibrate` (ciemss#445)

* added progress hook for calibrate

* added test with simple logging

* lint

* Fix formatting, linting, etc

---------

Co-authored-by: Sam Witty <samawitty@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djinnome djinnome djinnome approved these changes

Assignees

@SamWitty SamWitty

Labels
integration Tasks for integration with TA4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SamWitty @djinnome