generated from cloud-gov/pages-uswds-11ty
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ticket #1693: Implement "check availability" section on get.gov/domains/choosing/ #269
Merged
zandercymatics
merged 42 commits into
main
from
za/1693-implement-check-availability-section
Apr 18, 2024
Merged
Changes from 12 commits
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
35d6ab6
Basic search
zandercymatics 309edd3
Update domains_choosing.md
zandercymatics 4ae3742
Update domains_choosing.md
zandercymatics 57f9c60
Test wrapping in grid
zandercymatics ce5ed93
Update styling
zandercymatics 16a71a2
Add padding
zandercymatics 637cdc2
Embed script
zandercymatics 691bf75
Fix button
zandercymatics d676f93
Move script location
zandercymatics aa29e80
Fine tuning
zandercymatics d42fee7
Add margin top
zandercymatics 84853e6
Add whois link
zandercymatics 44b7b09
Update info-page.html
zandercymatics 73d7a7c
Update info-page.html
zandercymatics 0ed140f
Add whois section
zandercymatics 0cd1bfc
Update info-page.html
zandercymatics e01db2b
Add styles for mobile
zandercymatics c778608
Remove br
zandercymatics 0d8a199
Add to includes
zandercymatics d5aa787
Remove white space
zandercymatics ae50d31
Show/hide error message dynamically
zandercymatics 1150ab8
Fix display none
zandercymatics 4c13c90
Update info-page.html
zandercymatics 199828b
Add custom height to error alert
zandercymatics d977cc3
Add margin bottom
zandercymatics 9490b60
Test consolidating scripts
zandercymatics bf03a09
Link script
zandercymatics 3db9cba
Test
zandercymatics 4e1fe10
Move script location
zandercymatics db094f7
Add flag
zandercymatics ebb1d5c
Change id
zandercymatics 6b1c398
THE apostrophe
zandercymatics 83770bb
Add manage.get.gov colors
zandercymatics 8bbfc6c
Cleanup
zandercymatics 6ca7441
Test
zandercymatics 7522251
test2
zandercymatics a4f4ea8
Move availability form
zandercymatics d6def4d
Add DOM loaded listener
zandercymatics 7726cce
Revert "Add DOM loaded listener"
zandercymatics 47d0df1
Fix styling issues, move to js
zandercymatics f205961
Fix hatch - revert js change
zandercymatics 471223c
Change excerpt
zandercymatics File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking: If we have to duplicate this code, you should put comments on both sides in all caps so that we do not update this in one place and miss it in the other. I'm particularly thinking about that comment on Ticket #267.
But first, see next comment on trying things to avoid this particular code duplication.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Figured out how to do this without CSRF issues by moving it to the meta file. This comes with the added benefit of centralizing all our scripts moving forward.
I tried directly embedding the script in app.js, then a custom script called get-gov-home.js but:
I suggest resolving that issue in another ticket, it is purely a config thing