-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ticket #1693: Implement "check availability" section on get.gov/domains/choosing/ #269
Ticket #1693: Implement "check availability" section on get.gov/domains/choosing/ #269
Conversation
@rachidatecs Got your suggestions in! |
pages/domains/domains_choosing.md
Outdated
@@ -11,7 +11,42 @@ eleventyNavigation: | |||
title: Choosing your .gov domain name | |||
--- | |||
|
|||
|
|||
## Start your .gov domain search | |||
Check if the .gov domain you want is available. We'll work with you to find the best domain for your organization that meets our requirements. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zandercymatics can you change that pesky hatch mark to a apostrophe please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
} | ||
|
||
successMessage = ` | ||
<div class="usa-alert usa-alert--success usa-alert--slim" role="alert"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zandercymatics I can't believe I'm just now noticing this, but the success and error alerts on this page and on the home page check availability don't use our .gov custom color alerts. Can we make these alerts match the ones on the registrar?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
This comment was marked as resolved.
This comment was marked as resolved.
height: 3.5rem; | ||
} | ||
|
||
p { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking: only the last child. Should look like p:last-of-type or similar
@zandercymatics On mobile, the field + text doesn't span the width of the button. Can you make it match? This screenshot is from my iphone 13 but when testing in desktop it seems to "break" at around 401px and below. |
Can I get a content update too? After chatting with Katherine we agreed it would be great to update the text on the card on /domains to point to this new feature. Can we change the body text of the card to:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Ticket
Resolves #1693
Changes
Context for reviewers
This PR adds a check availability module to the domains/choosing page.
Setup
Code Review Verification Steps
As the original developer, I have
Satisfied acceptance criteria and met development standards
Ensured code standards are met (Original Developer)
Validated user-facing changes (if applicable)
As a code reviewer, I have
Reviewed, tested, and left feedback about the changes
Ensured code standards are met (Code reviewer)
Validated user-facing changes as a developer
New pages have been added to .pa11yci file so that they will be tested with our automated accessibility testing
Checked keyboard navigability
Meets all designs and user flows provided by design/product
Tested general usability, landmarks, page header structure, and links with a screen reader (such as Voiceover or ANDI)
Tested with multiple browsers, the suggestion is to use ones that the developer didn't (check off which ones were used)
(Rarely needed) Tested as both an analyst and applicant user
Note: Multiple code reviewers can share the checklists above, a second reviewers should not make a duplicate checklist
As a designer reviewer, I have
Verified that the changes match the design intention
Validated user-facing changes as a designer
Checked keyboard navigability
Tested general usability, landmarks, page header structure, and links with a screen reader (such as Voiceover or ANDI)
Tested with multiple browsers (check off which ones were used)
(Rarely needed) Tested as both an analyst and applicant user
Screenshots