Ticket #1693: Implement "check availability" section on get.gov/domains/choosing/ #269

zandercymatics · 2024-04-11T17:59:00Z

Ticket

Resolves #1693

Changes

Adds a check availability module to the domains/choosing page

Context for reviewers

This PR adds a check availability module to the domains/choosing page.

Setup

Click "domains" at the nav bar on the top, then click "Choosing your .gov domain name"
Test the input field and verify it matches with the figma

Code Review Verification Steps

As the original developer, I have

Satisfied acceptance criteria and met development standards

Met the acceptance criteria, or will meet them in a subsequent PR
Created/modified automated tests
Added at least 2 developers as PR reviewers (only 1 will need to approve)
Messaged on Slack or in standup to notify the team that a PR is ready for review
Changes to “how we do things” are documented in READMEs and or onboarding guide
If any model was updated to modify/add/delete columns, makemigrations was ran and the assoicated migrations file has been commited.

Ensured code standards are met (Original Developer)

All new functions and methods are commented using plain language
Did dependency updates in Pipfile also get changed in requirements.txt?
Interactions with external systems are wrapped in try/except
Error handling exists for unusual or missing values

Validated user-facing changes (if applicable)

New pages have been added to .pa11yci file so that they will be tested with our automated accessibility testing
Checked keyboard navigability
Tested general usability, landmarks, page header structure, and links with a screen reader (such as Voiceover or ANDI)
Add at least 1 designer as PR reviewer

As a code reviewer, I have

Reviewed, tested, and left feedback about the changes

Pulled this branch locally and tested it
Reviewed this code and left comments
Checked that all code is adequately covered by tests
Made it clear which comments need to be addressed before this work is merged
If any model was updated to modify/add/delete columns, makemigrations was ran and the assoicated migrations file has been commited.

Ensured code standards are met (Code reviewer)

All new functions and methods are commented using plain language
Interactions with external systems are wrapped in try/except
Error handling exists for unusual or missing values
(Rarely needed) Did dependency updates in Pipfile also get changed in requirements.txt?

Validated user-facing changes as a developer

Note: Multiple code reviewers can share the checklists above, a second reviewers should not make a duplicate checklist

As a designer reviewer, I have

Verified that the changes match the design intention

Checked that the design translated visually
Checked behavior
Checked different states (empty, one, some, error)
Checked for landmarks, page heading structure, and links
Tried to break the intended flow

Validated user-facing changes as a designer

Checked keyboard navigability
Tested general usability, landmarks, page header structure, and links with a screen reader (such as Voiceover or ANDI)
Tested with multiple browsers (check off which ones were used)
- Chrome
- Microsoft Edge
- FireFox
- Safari
(Rarely needed) Tested as both an analyst and applicant user

Screenshots

_includes/layouts/info-page.html

Addressed changes

zandercymatics · 2024-04-17T20:05:44Z

@rachidatecs Got your suggestions in!

gabydisarli · 2024-04-17T20:38:45Z

pages/domains/domains_choosing.md

@@ -11,7 +11,42 @@ eleventyNavigation:
  title: Choosing your .gov domain name
 ---

-
+## Start your .gov domain search
+Check if the .gov domain you want is available. We'll work with you to find the best domain for your organization that meets our requirements.


@zandercymatics can you change that pesky hatch mark to a apostrophe please?

gabydisarli · 2024-04-17T22:31:33Z

_includes/meta.html

+              }
+
+              successMessage = `
+              <div class="usa-alert usa-alert--success usa-alert--slim" role="alert">


@zandercymatics I can't believe I'm just now noticing this, but the success and error alerts on this page and on the home page check availability don't use our .gov custom color alerts. Can we make these alerts match the ones on the registrar?

zandercymatics · 2024-04-18T14:09:48Z

we have another error message if the person has entered a domain name with invalid characters. Can we add that here?

Hey Gaby, that error message already exists on the page!

rachidatecs · 2024-04-18T14:37:39Z

styles/_uswds-theme-custom-styles.scss

+    height: 3.5rem;
+  }
+
+  p {


Blocking: only the last child. Should look like p:last-of-type or similar

pages/domains/domains_choosing.md

_includes/meta.html

This reverts commit d6def4d.

gabydisarli · 2024-04-18T15:31:12Z

@zandercymatics On mobile, the field + text doesn't span the width of the button. Can you make it match? This screenshot is from my iphone 13 but when testing in desktop it seems to "break" at around 401px and below.

gabydisarli · 2024-04-18T15:33:23Z

Can I get a content update too? After chatting with Katherine we agreed it would be great to update the text on the card on /domains to point to this new feature. Can we change the body text of the card to:

Check if a domain is available and read name requirements for your organization

gabydisarli · 2024-04-18T15:38:13Z

Caught another errant hatch mark 🙃

gabydisarli

Looks great!

zandercymatics added 12 commits April 10, 2024 13:47

Basic search

35d6ab6

Update domains_choosing.md

309edd3

Update domains_choosing.md

4ae3742

Test wrapping in grid

57f9c60

Update styling

ce5ed93

Add padding

16a71a2

Embed script

637cdc2

Fix button

691bf75

Move script location

d676f93

Fine tuning

aa29e80

Add margin top

d42fee7

Add whois link

84853e6

github-advanced-security bot found potential problems Apr 12, 2024

View reviewed changes

_includes/layouts/info-page.html Fixed Show fixed Hide fixed

Update info-page.html

44b7b09

github-advanced-security bot found potential problems Apr 12, 2024

View reviewed changes

_includes/layouts/info-page.html Fixed Show fixed Hide fixed

zandercymatics added 11 commits April 12, 2024 11:24

Update info-page.html

73d7a7c

Add whois section

0ed140f

Update info-page.html

0cd1bfc

Add styles for mobile

e01db2b

Remove br

c778608

Add to includes

0d8a199

Remove white space

d5aa787

Show/hide error message dynamically

ae50d31

Fix display none

1150ab8

Update info-page.html

4c13c90

Add custom height to error alert

199828b

zandercymatics requested review from therealslimhsiehdy, CocoByte, rachidatecs and abroddrick April 12, 2024 19:01

zandercymatics added 2 commits April 17, 2024 13:51

Add flag

db094f7

Change id

ebb1d5c

gabydisarli reviewed Apr 17, 2024

View reviewed changes

THE apostrophe

6b1c398

gabydisarli reviewed Apr 17, 2024

View reviewed changes

This comment was marked as resolved.

Sign in to view

zandercymatics requested a review from rachidatecs April 18, 2024 14:15

zandercymatics added 2 commits April 18, 2024 08:19

Add manage.get.gov colors

83770bb

Cleanup

8bbfc6c

rachidatecs reviewed Apr 18, 2024

View reviewed changes

zandercymatics added 5 commits April 18, 2024 08:50

Test

6ca7441

test2

7522251

Move availability form

a4f4ea8

Add DOM loaded listener

d6def4d

Revert "Add DOM loaded listener"

7726cce

This reverts commit d6def4d.

zandercymatics added 3 commits April 18, 2024 09:43

Fix styling issues, move to js

47d0df1

Fix hatch - revert js change

f205961

Change excerpt

471223c

rachidatecs approved these changes Apr 18, 2024

View reviewed changes

gabydisarli self-requested a review April 18, 2024 16:34

gabydisarli approved these changes Apr 18, 2024

View reviewed changes

zandercymatics merged commit 6c4b27b into main Apr 18, 2024
4 checks passed

zandercymatics deleted the za/1693-implement-check-availability-section branch April 18, 2024 16:35

zandercymatics restored the za/1693-implement-check-availability-section branch May 3, 2024 20:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ticket #1693: Implement "check availability" section on get.gov/domains/choosing/ #269

Ticket #1693: Implement "check availability" section on get.gov/domains/choosing/ #269

zandercymatics commented Apr 11, 2024 •

edited by gabydisarli

Loading

zandercymatics commented Apr 17, 2024

gabydisarli Apr 17, 2024

zandercymatics Apr 17, 2024

gabydisarli Apr 17, 2024

zandercymatics Apr 18, 2024

This comment was marked as resolved.

zandercymatics commented Apr 18, 2024

rachidatecs Apr 18, 2024

gabydisarli commented Apr 18, 2024

gabydisarli commented Apr 18, 2024

gabydisarli commented Apr 18, 2024

gabydisarli left a comment

Ticket #1693: Implement "check availability" section on get.gov/domains/choosing/ #269

Ticket #1693: Implement "check availability" section on get.gov/domains/choosing/ #269

Conversation

zandercymatics commented Apr 11, 2024 • edited by gabydisarli Loading

Ticket

Changes

Context for reviewers

Setup

Code Review Verification Steps

As the original developer, I have

Satisfied acceptance criteria and met development standards

Ensured code standards are met (Original Developer)

Validated user-facing changes (if applicable)

As a code reviewer, I have

Reviewed, tested, and left feedback about the changes

Ensured code standards are met (Code reviewer)

Validated user-facing changes as a developer

As a designer reviewer, I have

Verified that the changes match the design intention

Validated user-facing changes as a designer

Screenshots

zandercymatics commented Apr 17, 2024

gabydisarli Apr 17, 2024

Choose a reason for hiding this comment

zandercymatics Apr 17, 2024

Choose a reason for hiding this comment

gabydisarli Apr 17, 2024

Choose a reason for hiding this comment

zandercymatics Apr 18, 2024

Choose a reason for hiding this comment

This comment was marked as resolved.

zandercymatics commented Apr 18, 2024

rachidatecs Apr 18, 2024

Choose a reason for hiding this comment

gabydisarli commented Apr 18, 2024

gabydisarli commented Apr 18, 2024

gabydisarli commented Apr 18, 2024

gabydisarli left a comment

Choose a reason for hiding this comment

zandercymatics commented Apr 11, 2024 •

edited by gabydisarli

Loading