Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ticket #1693: Implement "check availability" section on get.gov/domains/choosing/ #269
Ticket #1693: Implement "check availability" section on get.gov/domains/choosing/ #269
Changes from 31 commits
35d6ab6
309edd3
4ae3742
57f9c60
ce5ed93
16a71a2
637cdc2
691bf75
d676f93
aa29e80
d42fee7
84853e6
44b7b09
73d7a7c
0ed140f
0cd1bfc
e01db2b
c778608
0d8a199
d5aa787
ae50d31
1150ab8
4c13c90
199828b
d977cc3
9490b60
bf03a09
3db9cba
4e1fe10
db094f7
ebb1d5c
6b1c398
83770bb
8bbfc6c
6ca7441
7522251
a4f4ea8
d6def4d
7726cce
47d0df1
f205961
471223c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zandercymatics I can't believe I'm just now noticing this, but the success and error alerts on this page and on the home page check availability don't use our .gov custom color alerts. Can we make these alerts match the ones on the registrar?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zandercymatics can you change that pesky hatch mark to a apostrophe please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reading on style guides for markdown, this is semantically fine.
Ideally I want to embed this in _includes, but we get a CSRF error when we do so for some reason. It seems to be a config issue.
It seems like others have gotten around this with liquidcode, but to stay consistent we need to wrap all of that in one line. Thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking: only the last child. Should look like p:last-of-type or similar