Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRM-21197 Convert from html to plain text AFTER token substitution has happened - take 2 #12061

Closed
wants to merge 1 commit into from

Conversation

michaelmcandrew
Copy link
Contributor

@michaelmcandrew michaelmcandrew commented Apr 30, 2018

Overview

This is a second attempt at addressing CRM-21197. It is exactly the same as the first attempt (which was initially merged and then rejected) but is now accompanied by a patch to Flexmailer.

Is essence, the basis for the patch is as follows:

When no plain text version of an email is submitted, conversion from HTML to plain text should happen once, using the full HTML of the HTML version of the email after token substitution and click tracking.

@totten, in #10998, you suggested that TokenRow::format might provide the fuctionality we need to handle plain text tokens, but I don't think they are applicable in this use case. I think they are useful when the message is plain text but not in this case, when the message is HTML that needs to be converted to plain text.


@eileenmcnaughton eileenmcnaughton changed the title CRM-21197 - take 2 CRM-21197 Convert from html to plain text AFTER token substitution has happened - take 2 Apr 30, 2018
@michaelmcandrew
Copy link
Contributor Author

jenkins test this please

@michaelmcandrew
Copy link
Contributor Author

see full discussion in https://lab.civicrm.org/dev/mail/issues/3

@colemanw
Copy link
Member

@michaelmcandrew looks like a related test failure in the mailing system.

@eileenmcnaughton
Copy link
Contributor

@michaelmcandrew this stalled on a related test fail - & I think from lack of current enthusiasm? I'd lean towards closing & re-opening when you find a revitalised enthusiasm for it

@colemanw colemanw closed this Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants