CRM-21197 Convert from html to plain text AFTER token substitution has happened - take 2 #12061
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This is a second attempt at addressing CRM-21197. It is exactly the same as the first attempt (which was initially merged and then rejected) but is now accompanied by a patch to Flexmailer.
Is essence, the basis for the patch is as follows:
When no plain text version of an email is submitted, conversion from HTML to plain text should happen once, using the full HTML of the HTML version of the email after token substitution and click tracking.
@totten, in #10998, you suggested that
TokenRow::format
might provide the fuctionality we need to handle plain text tokens, but I don't think they are applicable in this use case. I think they are useful when the message is plain text but not in this case, when the message is HTML that needs to be converted to plain text.