This repository has been archived by the owner on Feb 6, 2023. It is now read-only.
autogenerate the plain text version after token substitution #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@michaelmcandrew just a few failures https://test.civicrm.org/job/CiviCRM-FlexMailer-PR/13/ :-) |
|
jenkins test this please |
|
Once the tests pass here, I should ask tim to review civicrm/civicrm-core#12061 |
|
jenkins test this please now that https://github.com/civicrm/civicrm-core/pull/12026/files has been merged |
|
see full discussion in https://lab.civicrm.org/dev/mail/issues/3 |
|
jenkins, test this please |
|
Tests seem to be passing? https://test.civicrm.org/job/Extension-SHA/749/console @michaelmcandrew Have you been running this patch for the past 2 years? Is there anything that you might think could be blocking a merge? (I won't merge it, but I can try to get another merger to review it) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR alters
DefaultComposeras follows:Only create a body_text (text/plain)
message for TokenProcessor if body_text has been specified. If it has not bee specified, set$autoGeneratePlainText` to true for DefaultComposer so we know to auto generate the plain text version later onOnce any token substitution and link tracking has happened, if no plain text version has been specified, run the generated HTML through
CRM_Utils_String::htmlToTextto create a plain text version of the email.See associated PR on civicrm-core for more details.