Add the ability to flag previously-supported accessories & platforms as not (currently) supported #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… arms, whose binary drivers don't exist in Jazzy yet)
civerachb-cpr
added
enhancement
civerachb-cpr
requested review from
tonybaltovski,
mhosmar-cpr,
roni-kreinin,
luis-camero and
hilary-luo
and removed request for
a team
…f hard-coding the distro
…ngs with f'' strings.
…jor code tidying-up should be done now
civerachb-cpr
force-pushed
the
cib/unsupported-jazzy
branch
from
fa883ab
to
8908f9e
Compare
…ircular dependency. Instead use the system level envar
|
Added a similar exception for the W200 to mark it as unsupported. |
civerachb-cpr
changed the title
mhosmar-cpr
reviewed
Nov 5, 2024
| angular.z.min_velocity": -2.0 | ||
| angular.z.max_acceleration": 6.0 | ||
| angular.z.min_acceleration": -6.0 | ||
| linear.x.max_velocity': 1.0 |
There was a problem hiding this comment.
Should these quotes have a corresponding quote to make a pair?
There was a problem hiding this comment.
Good catch. I'm not sure why these appear to have been missing the matching quotation marks in the first place, but I've fixed them up now.
…ructure to avoid `foo.bar.spam: eggs` notation
luis-camero
reviewed
Nov 5, 2024
luis-camero
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than removing them completely, we can override the
assert_is_supportedmethod to raise the necessary exception, which will have the same effect as a failed assertion.I opted to raise the exception since it allows nicer exception handling at a higher level and could allow for better logging than a simple
assert self.is_supported, 'This accessory isn't supported'style.