Add clojure-ts-mode support #3622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This does NOT intended to break the dependency from cider to clojure-mode. It is intended to make CIDER work with clojure-ts-mode. Some functionality like clojure-find-ns, clojulore-find-def, etc will still require clojure-mode in order for CIDER to get it's work done. Adds util functions for checking if buffer is managed by a clojure mode
Address cl-flet lint warning ... with a simpler implementation of cider--setup-clojure-major-mode. Can't have cl-flet lint warnings if I don't use cl-flet. Add clojure-ts-mode dependency to Eldev Silence byte-compiler when optional clojure-ts-mode is not available The linter throws a warning when byte-compiling. Eldev doesn't support pulling in dependencies declared with `eldev-add-extra-dependencies` while running the `eldev compile` command. See https://emacs-eldev.github.io/eldev/#additional-dependencies This makes sense. If a user is byte compiling cider and they don't have clojure-ts-mode installed, they shouldn't see a byte compile warning for it. Make clojure-ts-mode dependency optional Tests will fail when using Emacs versions less than 29 because clojure-ts-mode requires Emacs 29 to work properly. That could be why tests fail in CI. This probably won't help with the linting issue
Includes top level "main" tests, plus an additional clojure-ts-mode/* tests. This also tries to install the language grammar in the CI environment. Git and CC are required. This works in github actions
Particularly the caveats page, where we describe some of the things clojure-ts-mode is currently lacking.
6 tasks
|
Looks good to me. Thanks for driving this to the finish line! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #3461