-
-
Notifications
You must be signed in to change notification settings - Fork 645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add clojure-ts-mode support #3622
Merged
Merged
Commits on Oct 24, 2023
-
Add preliminary support for clojure-ts-mode
This does NOT intended to break the dependency from cider to clojure-mode. It is intended to make CIDER work with clojure-ts-mode. Some functionality like clojure-find-ns, clojulore-find-def, etc will still require clojure-mode in order for CIDER to get it's work done. Adds util functions for checking if buffer is managed by a clojure mode
Configuration menu - View commit details
-
Copy full SHA for 1a3b13d - Browse repository at this point
Copy the full SHA 1a3b13dView commit details -
Address cl-flet lint warning ... with a simpler implementation of cider--setup-clojure-major-mode. Can't have cl-flet lint warnings if I don't use cl-flet. Add clojure-ts-mode dependency to Eldev Silence byte-compiler when optional clojure-ts-mode is not available The linter throws a warning when byte-compiling. Eldev doesn't support pulling in dependencies declared with `eldev-add-extra-dependencies` while running the `eldev compile` command. See https://emacs-eldev.github.io/eldev/#additional-dependencies This makes sense. If a user is byte compiling cider and they don't have clojure-ts-mode installed, they shouldn't see a byte compile warning for it. Make clojure-ts-mode dependency optional Tests will fail when using Emacs versions less than 29 because clojure-ts-mode requires Emacs 29 to work properly. That could be why tests fail in CI. This probably won't help with the linting issue
Configuration menu - View commit details
-
Copy full SHA for d328a77 - Browse repository at this point
Copy the full SHA d328a77View commit details -
Run tests against clojure-ts-mode
Includes top level "main" tests, plus an additional clojure-ts-mode/* tests. This also tries to install the language grammar in the CI environment. Git and CC are required. This works in github actions
Configuration menu - View commit details
-
Copy full SHA for cfba8f1 - Browse repository at this point
Copy the full SHA cfba8f1View commit details -
Update documentation to reflect clojure-ts-mode support
Particularly the caveats page, where we describe some of the things clojure-ts-mode is currently lacking.
Configuration menu - View commit details
-
Copy full SHA for 564ba6f - Browse repository at this point
Copy the full SHA 564ba6fView commit details -
Configuration menu - View commit details
-
Copy full SHA for b3a2f89 - Browse repository at this point
Copy the full SHA b3a2f89View commit details -
Configuration menu - View commit details
-
Copy full SHA for e2efc95 - Browse repository at this point
Copy the full SHA e2efc95View commit details
Commits on Feb 18, 2024
-
Configuration menu - View commit details
-
Copy full SHA for ad7fc6e - Browse repository at this point
Copy the full SHA ad7fc6eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5a98220 - Browse repository at this point
Copy the full SHA 5a98220View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5eb543d - Browse repository at this point
Copy the full SHA 5eb543dView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.