Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clojure-ts-mode support #3622

Merged
merged 9 commits into from
Feb 18, 2024
Merged

Commits on Oct 24, 2023

  1. Add preliminary support for clojure-ts-mode

    This does NOT intended to break the dependency from cider to
    clojure-mode. It is intended to make CIDER work with clojure-ts-mode.
    
    Some functionality like clojure-find-ns, clojulore-find-def, etc will
    still require clojure-mode in order for CIDER to get it's work done.
    
    Adds util functions for checking if buffer is managed by a clojure mode
    dannyfreeman committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    1a3b13d View commit details
    Browse the repository at this point in the history
  2. Address Linting warnings

    Address cl-flet lint warning
    
    ... with a simpler implementation of cider--setup-clojure-major-mode.
    Can't have cl-flet lint warnings if I don't use cl-flet.
    
    Add clojure-ts-mode dependency to Eldev
    
    Silence byte-compiler when optional clojure-ts-mode is not available
    
    The linter throws a warning when byte-compiling. Eldev doesn't support
    pulling in dependencies declared with `eldev-add-extra-dependencies`
    while running the `eldev compile` command. See
    https://emacs-eldev.github.io/eldev/#additional-dependencies
    
    This makes sense. If a user is byte compiling cider and they don't have
    clojure-ts-mode installed, they shouldn't see a byte compile warning for
    it.
    
    Make clojure-ts-mode dependency optional
    
    Tests will fail when using Emacs versions less than 29 because
    clojure-ts-mode requires Emacs 29 to work properly. That could be why
    tests fail in CI. This probably won't help with the linting issue
    dannyfreeman committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    d328a77 View commit details
    Browse the repository at this point in the history
  3. Run tests against clojure-ts-mode

    Includes top level "main" tests, plus an additional
    clojure-ts-mode/* tests.
    
    This also tries to install the language grammar in the CI environment.
    Git and CC are required. This works in github actions
    dannyfreeman committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    cfba8f1 View commit details
    Browse the repository at this point in the history
  4. Update documentation to reflect clojure-ts-mode support

    Particularly the caveats page, where we describe some of the things
    clojure-ts-mode is currently lacking.
    dannyfreeman committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    564ba6f View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    b3a2f89 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    e2efc95 View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2024

  1. Configuration menu
    Copy the full SHA
    ad7fc6e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5a98220 View commit details
    Browse the repository at this point in the history
  3. Update changelog

    kommen committed Feb 18, 2024
    Configuration menu
    Copy the full SHA
    5eb543d View commit details
    Browse the repository at this point in the history