feat: Add tokenless mutation and field in owner #826

RulaKhaled · 2024-09-16T12:23:01Z

Purpose/Motivation

What is the feature? Why is this being done?
The user will set tokenless to either true or false. We need tokens_required to reflect the current status of tokenless within the organization, and we need a mutation to set tokenless to either required or not

this PR depends on:

Add new tokens_required field for owners table #2297

Links to relevant tickets

[API] Expose new tokens_required field via graphql
[API] Add new require token mutation

What does this PR do?

Include a brief description of the changes in this PR. Bullet points are your friend.

mutation
new field under owner query
tests

Notes to Reviewer

Anything to note to the team? Any tips on how to review, or where to start?

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

adrian-codecov · 2024-09-16T15:06:22Z

graphql_api/types/owner/owner.graphql

@@ -37,4 +37,5 @@ type Owner {
  ): RepositoryConnection! @cost(complexity: 25, multipliers: ["first", "last"])
  username: String
  yaml: String
+  tokensRequierd: Boolean 


Also, when would this field be set to Null instead of true/false?

yep, when user is not part of the org (decorator rules)

adrian-codecov · 2024-09-16T15:10:08Z

codecov_auth/commands/owner/interactors/set_tokens_required.py

+
+        self.validate(owner_obj)
+
+        owner_obj.tokens_required = typed_input.tokens_required


Thoughts on this being token_required? And even to be more explicit, upload_token required?

We use the github/providers token for other things, so differentiating this as the "codecov_token" or "upload_token" would make more sense. I also don't know if this exclusively a coverage token or if it also applies to bundle_analysis/test_results, so I'd confirm what's the expected behavior, and if it is exclusively for coverage (and we don't intend to do it for BA/TR), then I'd call it coverage_token or upload_coverage_token or something like that

This is just a draft PR not the final code, just put tokens_required as it's the suggested name by Trent for Nora, so i will change the name according to what it's called in the DB to avoid any confusion

Sounds good! 👌

changed to upload_token_required!

codecov-notifications · 2024-10-04T14:28:26Z

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

codecov · 2024-10-04T14:28:27Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.34%. Comparing base (f46d73a) to head (fe1ec6b).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #826      +/-   ##
==========================================
+ Coverage   96.33%   96.34%   +0.01%     
==========================================
  Files         820      823       +3     
  Lines       19102    19157      +55     
==========================================
+ Hits        18402    18457      +55     
  Misses        700      700

Flag	Coverage Δ
unit	`92.71% <100.00%> (+0.02%)`	⬆️
unit-latest-uploader	`92.71% <100.00%> (+0.02%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

adrian-codecov · 2024-10-07T18:17:31Z

codecov_auth/commands/owner/interactors/set_upload_token_required.py

+        if not current_user_part_of_org(self.current_owner, owner_obj):
+            raise Unauthorized()
+        if not owner_obj.is_admin(self.current_owner):
+            raise Unauthorized("Admin authorization required")


Can upload_token_required be null? If not maybe do some validation here too

adrian-codecov · 2024-10-07T18:18:06Z

codecov_auth/commands/owner/interactors/tests/test_set_upload_token_required.py

+        self.owner_with_admins.refresh_from_db()
+        assert self.owner_with_admins.upload_token_required_for_public_repos == True
+
+    def test_set_upload_token_required_to_false(self):


I'd add a test here for the null case based on the above

adrian-codecov · 2024-10-07T18:20:11Z

graphql_api/types/mutation/set_upload_token_required/set_upload_token_required.graphql

+}
+
+input SetUploadTokenRequiredInput {
+  org_username: String!


Why is this snake and the below camel 👀 could we follow the camel convention pls?

Great catch

adrian-codecov · 2024-10-07T18:21:16Z

graphql_api/types/owner/owner.graphql

@@ -39,4 +39,5 @@ type Owner {
  yaml: String
  aiFeaturesEnabled: Boolean!
  aiEnabledRepos: [String]
+  uploadTokenRequired: Boolean


Is it intentional for this to be null? Seems the interactor only expects bool, and afaik we were going to backfill/default everyone to have false weren't we? That's what I recall from Nora

The decorator @require_part_of_org should return null if user is not part of the org!

codecov-qa · 2024-10-08T14:08:36Z

❌ 1 Tests Failed:

Tests completed	Failed	Passed	Skipped
2563	1	2562	6

View the top 1 failed tests by shortest run time

billing.tests.test_views.StripeWebhookHandlerTests test_customer_subscription_deleted_deactivates_all_repos_multiple_owner

Stack Traces | 0.034s run time

self = &lt;billing.tests.test_views.StripeWebhookHandlerTests testMethod=test_customer_subscription_deleted_deactivates_all_repos_multiple_owner&gt;

    def test_customer_subscription_deleted_deactivates_all_repos_multiple_owner(self):
        self.add_second_owner()
        RepositoryFactory(author=self.owner, activated=True, active=True)
        RepositoryFactory(author=self.owner, activated=True, active=True)
        RepositoryFactory(author=self.owner, activated=True, active=True)
        RepositoryFactory(author=self.other_owner, activated=True, active=True)
        RepositoryFactory(author=self.other_owner, activated=True, active=True)
        RepositoryFactory(author=self.other_owner, activated=True, active=True)
    
        self.owner.refresh_from_db()
        self.other_owner.refresh_from_db()
    
&gt;       assert (
            self.owner.repository_set.filter(activated=True, active=True).count() == 3
        )
E       assert 2 == 3
E        +  where 2 = &lt;bound method QuerySet.count of &lt;RepositoryQuerySet [&lt;Repository: Repo&lt;Owner&lt;github/stephen88&gt;/push&gt;&gt;, &lt;Repository: Repo&lt;Owner&lt;github/stephen88&gt;/nature&gt;&gt;]&gt;&gt;()
E        +    where &lt;bound method QuerySet.count of &lt;RepositoryQuerySet [&lt;Repository: Repo&lt;Owner&lt;github/stephen88&gt;/push&gt;&gt;, &lt;Repository: Repo&lt;Owner&lt;github/stephen88&gt;/nature&gt;&gt;]&gt;&gt; = &lt;RepositoryQuerySet [&lt;Repository: Repo&lt;Owner&lt;github/stephen88&gt;/push&gt;&gt;, &lt;Repository: Repo&lt;Owner&lt;github/stephen88&gt;/nature&gt;&gt;]&gt;.count
E        +      where &lt;RepositoryQuerySet [&lt;Repository: Repo&lt;Owner&lt;github/stephen88&gt;/push&gt;&gt;, &lt;Repository: Repo&lt;Owner&lt;github/stephen88&gt;/nature&gt;&gt;]&gt; = &lt;bound method QuerySet.filter of &lt;django.db.models.fields.related_descriptors.create_reverse_many_to_one_manager.&lt;locals&gt;.RelatedManager object at 0x7f6477d34620&gt;&gt;(activated=True, active=True)
E        +        where &lt;bound method QuerySet.filter of &lt;django.db.models.fields.related_descriptors.create_reverse_many_to_one_manager.&lt;locals&gt;.RelatedManager object at 0x7f6477d34620&gt;&gt; = &lt;django.db.models.fields.related_descriptors.create_reverse_many_to_one_manager.&lt;locals&gt;.RelatedManager object at 0x7f6477d34620&gt;.filter
E        +          where &lt;django.db.models.fields.related_descriptors.create_reverse_many_to_one_manager.&lt;locals&gt;.RelatedManager object at 0x7f6477d34620&gt; = &lt;Owner: Owner&lt;github/stephen88&gt;&gt;.repository_set
E        +            where &lt;Owner: Owner&lt;github/stephen88&gt;&gt; = &lt;billing.tests.test_views.StripeWebhookHandlerTests testMethod=test_customer_subscription_deleted_deactivates_all_repos_multiple_owner&gt;.owner

billing/tests/test_views.py:276: AssertionError

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

codecov-public-qa · 2024-10-08T14:08:36Z

Test Failures Detected: Due to failing tests, we cannot provide coverage reports at this time.

❌ Failed Test Results:

Completed 2569 tests with 1 failed, 2562 passed and 6 skipped.

View the full list of failed tests

pytest

Class name: billing.tests.test_views.StripeWebhookHandlerTests
Test name: test_customer_subscription_deleted_deactivates_all_repos_multiple_owner

self = <billing.tests.test_views.StripeWebhookHandlerTests testMethod=test_customer_subscription_deleted_deactivates_all_repos_multiple_owner>

    def test_customer_subscription_deleted_deactivates_all_repos_multiple_owner(self):
        self.add_second_owner()
        RepositoryFactory(author=self.owner, activated=True, active=True)
        RepositoryFactory(author=self.owner, activated=True, active=True)
        RepositoryFactory(author=self.owner, activated=True, active=True)
        RepositoryFactory(author=self.other_owner, activated=True, active=True)
        RepositoryFactory(author=self.other_owner, activated=True, active=True)
        RepositoryFactory(author=self.other_owner, activated=True, active=True)
    
        self.owner.refresh_from_db()
        self.other_owner.refresh_from_db()
    
>       assert (
            self.owner.repository_set.filter(activated=True, active=True).count() == 3
        )
E       assert 2 == 3
E        +  where 2 = <bound method QuerySet.count of <RepositoryQuerySet [<Repository: Repo<Owner<github/stephen88>/push>>, <Repository: Repo<Owner<github/stephen88>/nature>>]>>()
E        +    where <bound method QuerySet.count of <RepositoryQuerySet [<Repository: Repo<Owner<github/stephen88>/push>>, <Repository: Repo<Owner<github/stephen88>/nature>>]>> = <RepositoryQuerySet [<Repository: Repo<Owner<github/stephen88>/push>>, <Repository: Repo<Owner<github/stephen88>/nature>>]>.count
E        +      where <RepositoryQuerySet [<Repository: Repo<Owner<github/stephen88>/push>>, <Repository: Repo<Owner<github/stephen88>/nature>>]> = <bound method QuerySet.filter of <django.db.models.fields.related_descriptors.create_reverse_many_to_one_manager.<locals>.RelatedManager object at 0x7f6477d34620>>(activated=True, active=True)
E        +        where <bound method QuerySet.filter of <django.db.models.fields.related_descriptors.create_reverse_many_to_one_manager.<locals>.RelatedManager object at 0x7f6477d34620>> = <django.db.models.fields.related_descriptors.create_reverse_many_to_one_manager.<locals>.RelatedManager object at 0x7f6477d34620>.filter
E        +          where <django.db.models.fields.related_descriptors.create_reverse_many_to_one_manager.<locals>.RelatedManager object at 0x7f6477d34620> = <Owner: Owner<github/stephen88>>.repository_set
E        +            where <Owner: Owner<github/stephen88>> = <billing.tests.test_views.StripeWebhookHandlerTests testMethod=test_customer_subscription_deleted_deactivates_all_repos_multiple_owner>.owner

billing/tests/test_views.py:276: AssertionError

RulaKhaled requested a review from a team as a code owner September 16, 2024 12:23

RulaKhaled marked this pull request as draft September 16, 2024 12:23

adrian-codecov reviewed Sep 16, 2024

View reviewed changes

RulaKhaled added 3 commits October 4, 2024 11:41

feat: Add tokenless mutation and field in owner

5f3ff73

just basic renaming

60998e0

Finally unblocked

252707b

RulaKhaled force-pushed the tokens-required branch from a029513 to 252707b Compare October 4, 2024 14:17

RulaKhaled marked this pull request as ready for review October 4, 2024 14:18

RulaKhaled mentioned this pull request Oct 7, 2024

feat: Tokenless banners codecov/gazebo#3358

Merged

1 task

adrian-codecov reviewed Oct 7, 2024

View reviewed changes

adrian-codecov approved these changes Oct 7, 2024

View reviewed changes

RulaKhaled and others added 7 commits October 8, 2024 15:29

resolve Adrians comments

90f0f5d

feat: Add tokenless mutation and field in owner

0dfa634

just basic renaming

6463eeb

Finally unblocked

b90c31b

Merge branch 'main' into test-resolve-conflict

00041c2

update lint

74d8692

format file

fe1ec6b

RulaKhaled added this pull request to the merge queue Oct 8, 2024

Merged via the queue into main with commit b6b028c Oct 8, 2024
19 of 20 checks passed

RulaKhaled deleted the tokens-required branch October 8, 2024 14:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Add tokenless mutation and field in owner #826

feat: Add tokenless mutation and field in owner #826

RulaKhaled commented Sep 16, 2024 •

edited

Loading

adrian-codecov Sep 16, 2024

adrian-codecov Sep 16, 2024 •

edited

Loading

RulaKhaled Sep 16, 2024

RulaKhaled Oct 4, 2024

adrian-codecov Sep 16, 2024

RulaKhaled Sep 16, 2024

adrian-codecov Sep 16, 2024

RulaKhaled Oct 4, 2024

codecov-notifications bot commented Oct 4, 2024 •

edited

Loading

codecov bot commented Oct 4, 2024 •

edited

Loading

adrian-codecov Oct 7, 2024

RulaKhaled Oct 8, 2024

adrian-codecov Oct 7, 2024

adrian-codecov Oct 7, 2024

RulaKhaled Oct 8, 2024

adrian-codecov Oct 7, 2024 •

edited

Loading

RulaKhaled Oct 8, 2024 •

edited

Loading

codecov-qa bot commented Oct 8, 2024

codecov-public-qa bot commented Oct 8, 2024

pytest


		self.validate(owner_obj)

		owner_obj.tokens_required = typed_input.tokens_required

feat: Add tokenless mutation and field in owner #826

feat: Add tokenless mutation and field in owner #826

Conversation

RulaKhaled commented Sep 16, 2024 • edited Loading

Purpose/Motivation

Links to relevant tickets

What does this PR do?

Notes to Reviewer

Legal Boilerplate

Choose a reason for hiding this comment

adrian-codecov Sep 16, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov-notifications bot commented Oct 4, 2024 • edited Loading

Codecov Report

codecov bot commented Oct 4, 2024 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

adrian-codecov Oct 7, 2024 • edited Loading

Choose a reason for hiding this comment

RulaKhaled Oct 8, 2024 • edited Loading

Choose a reason for hiding this comment

codecov-qa bot commented Oct 8, 2024

❌ 1 Tests Failed:

codecov-public-qa bot commented Oct 8, 2024

❌ Failed Test Results:

pytest

RulaKhaled commented Sep 16, 2024 •

edited

Loading

adrian-codecov Sep 16, 2024 •

edited

Loading

codecov-notifications bot commented Oct 4, 2024 •

edited

Loading

codecov bot commented Oct 4, 2024 •

edited

Loading

adrian-codecov Oct 7, 2024 •

edited

Loading

RulaKhaled Oct 8, 2024 •

edited

Loading