Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Small tweaks to utils and hooks for BA on the Commit Detail Page #2540

Merged
merged 9 commits into from
Jan 26, 2024

Conversation

nicholas-codecov
Copy link
Contributor

Description

This PR fixes a couple of pieces required for adding BA into the Commit Detail Page.

GH codecov/engineering-team#996

Note

Requires #2535 to be merged first

Notable Changes

  • Fix issue with negative sizes in formatSizeToString
  • Return commit directly from commit dropdown summary hooks
  • Fix to the useCommitBundleList hook

Copy link

codecov-public-qa bot commented Jan 26, 2024

Codecov Report

Merging #2540 (dc5dab6) into main (a78abb5) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2540   +/-   ##
=======================================
  Coverage   98.31%   98.31%           
=======================================
  Files         803      803           
  Lines       10397    10400    +3     
  Branches     2573     2624   +51     
=======================================
+ Hits        10222    10225    +3     
  Misses        173      173           
  Partials        2        2           
Files Coverage Δ
src/services/commit/useCommitBADropdownSummary.tsx 100.00% <100.00%> (ø)
src/services/commit/useCommitBundleList.tsx 100.00% <ø> (ø)
...rvices/commit/useCommitCoverageDropdownSummary.tsx 100.00% <100.00%> (ø)
src/shared/utils/bundleAnalysis.ts 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 59.37% <ø> (ø)
Layouts 96.95% <ø> (ø)
Pages 99.25% <ø> (ø)
Services 99.55% <100.00%> (+<0.01%) ⬆️
Shared 99.82% <100.00%> (+<0.01%) ⬆️
UI 94.23% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a78abb5...dc5dab6. Read the comment docs.

@codecov-staging
Copy link

codecov-staging bot commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2540   +/-   ##
=======================================
  Coverage   98.31%   98.31%           
=======================================
  Files         803      803           
  Lines       10397    10400    +3     
  Branches     2617     2619    +2     
=======================================
+ Hits        10222    10225    +3     
  Misses        173      173           
  Partials        2        2           
Files Coverage Δ
src/services/commit/useCommitBADropdownSummary.tsx 100.00% <100.00%> (ø)
src/services/commit/useCommitBundleList.tsx 100.00% <ø> (ø)
...rvices/commit/useCommitCoverageDropdownSummary.tsx 100.00% <100.00%> (ø)
src/shared/utils/bundleAnalysis.ts 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 59.37% <ø> (ø)
Layouts 96.95% <ø> (ø)
Pages 99.25% <ø> (ø)
Services 99.55% <100.00%> (+<0.01%) ⬆️
Shared 99.82% <100.00%> (+<0.01%) ⬆️
UI 94.23% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a78abb5...dc5dab6. Read the comment docs.

Copy link

codecov bot commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a78abb5) 98.32% compared to head (dc5dab6) 98.32%.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2540   +/-   ##
=====================================
  Coverage   98.32   98.32           
=====================================
  Files        803     803           
  Lines      10397   10400    +3     
  Branches    2571    2624   +53     
=====================================
+ Hits       10222   10225    +3     
  Misses       173     173           
  Partials       2       2           
Files Coverage Δ
src/services/commit/useCommitBADropdownSummary.tsx 100.00% <100.00%> (ø)
src/services/commit/useCommitBundleList.tsx 100.00% <ø> (ø)
...rvices/commit/useCommitCoverageDropdownSummary.tsx 100.00% <100.00%> (ø)
src/shared/utils/bundleAnalysis.ts 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 59.37% <ø> (ø)
Layouts 96.95% <ø> (ø)
Pages 99.25% <ø> (ø)
Services 99.55% <100.00%> (+<0.01%) ⬆️
Shared 99.82% <100.00%> (+<0.01%) ⬆️
UI 94.23% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a78abb5...dc5dab6. Read the comment docs.

Copy link

netlify bot commented Jan 26, 2024

Deploy Preview for gazebo-staging ready!

Name Link
🔨 Latest commit dc5dab6
🔍 Latest deploy log https://app.netlify.com/sites/gazebo-staging/deploys/65b3bf72bb58750008a2d41e
😎 Deploy Preview https://deploy-preview-2540--gazebo-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov-qa
Copy link

codecov-qa bot commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a78abb5) 98.31% compared to head (dc5dab6) 98.31%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2540   +/-   ##
=======================================
  Coverage   98.31%   98.31%           
=======================================
  Files         803      803           
  Lines       10397    10400    +3     
  Branches     2617     2573   -44     
=======================================
+ Hits        10222    10225    +3     
  Misses        173      173           
  Partials        2        2           
Files Coverage Δ
src/services/commit/useCommitBADropdownSummary.tsx 100.00% <100.00%> (ø)
src/services/commit/useCommitBundleList.tsx 100.00% <ø> (ø)
...rvices/commit/useCommitCoverageDropdownSummary.tsx 100.00% <100.00%> (ø)
src/shared/utils/bundleAnalysis.ts 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 59.37% <ø> (ø)
Layouts 96.95% <ø> (ø)
Pages 99.25% <ø> (ø)
Services 99.55% <100.00%> (+<0.01%) ⬆️
Shared 99.82% <100.00%> (+<0.01%) ⬆️
UI 94.23% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a78abb5...dc5dab6. Read the comment docs.

@codecov-releaser
Copy link
Contributor

Visit https://preview-pr-2540.codecov.dev for your PR preview. Expires after 1 month automatically.

@nicholas-codecov nicholas-codecov merged commit 00ccb03 into main Jan 26, 2024
60 checks passed
@nicholas-codecov nicholas-codecov deleted the gh-eng-996-small-tweaks-to-utils-and-hooks branch January 26, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants