feat: Even more language support #3138
Conversation
nicholas-codecov
force-pushed
the
feat-even-more-languages-added
branch
from
2d4f17a
to
94a8b48
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3138 +/- ##
=======================================
Coverage 98.31% 98.31%
=======================================
Files 919 919
Lines 14177 14186 +9
Branches 3840 3840
=======================================
+ Hits 13938 13947 +9
Misses 234 234
Partials 5 5
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3138 +/- ##
=======================================
Coverage 98.31% 98.31%
=======================================
Files 919 919
Lines 14177 14186 +9
Branches 3921 3840 -81
=======================================
+ Hits 13938 13947 +9
Misses 234 234
Partials 5 5
Continue to review full report in Codecov by Sentry.
|
Bundle ReportChanges will increase total bundle size by 16.17kB ⬆️
|
Bundle ReportChanges will increase total bundle size by 16.17kB ⬆️
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3138 +/- ##
=======================================
Coverage 98.31% 98.31%
=======================================
Files 919 919
Lines 14177 14186 +9
Branches 3921 3926 +5
=======================================
+ Hits 13938 13947 +9
Misses 234 234
Partials 5 5
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #3138 +/- ##
===========================================
Coverage 98.31000 98.31000
===========================================
Files 919 919
Lines 14177 14186 +9
Branches 3926 3840 -86
===========================================
+ Hits 13938 13947 +9
Misses 234 234
Partials 5 5
Continue to review full report in Codecov by Sentry.
|
| @@ -17,6 +17,9 @@ import Prism from 'prism-react-renderer/prism' | |||
| */ | |||
| require('prismjs/components/prism-csharp') | |||
| require('prismjs/components/prism-dart') | |||
| require('prismjs/components/prism-cshtml') | |||
There was a problem hiding this comment.
just some food for thought: is it possible to load these on-demand after matching the file extension?
its also weird that you are using require here instead of bare import statements. is there a particular reason for that?
There was a problem hiding this comment.
Uhh was just following along with the example that they provided in the documentation for the package we're using, it seems like just replacing require with import everything works fine. Gonna quickly make the change to only load in the language required.
There was a problem hiding this comment.
Actually my "quick change" is a bit more involved, I think I'll merge what I have now, and tidy things up with your suggestion afterwards, sound all good to you @Swatinem ?
Description
This PR extends support for our file renderer with the following languages: