Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Use new flags and components graphql schema #3203

Merged
merged 9 commits into from
Oct 7, 2024
Merged

feat: Use new flags and components graphql schema #3203

merged 9 commits into from
Oct 7, 2024

Conversation

suejung-sentry
Copy link
Contributor

@suejung-sentry suejung-sentry commented Sep 17, 2024 •
edited
Loading

Point fields to the new resolvers for the nested types in CoverageAnalytics - flags and components (changes in api here).

Tested against local api and with unit tests that changes look okay. Also tested against the api changes in staging that the spots this is used have no difference in behavior (depends on this pr)

Closes codecov/engineering-team#2289

@codecov Codecov
Copy link

codecov bot commented Sep 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.17%. Comparing base (b133ce8) to head (7efd3f7).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3203   +/-   ##
=======================================
  Coverage   99.17%   99.17%           
=======================================
  Files         799      799           
  Lines       14093    14094    +1     
  Branches     3887     3887           
=======================================
+ Hits        13977    13978    +1     
  Misses        107      107           
  Partials        9        9
Files with missing lines Coverage Δ
...tabs/ConfigurationManager/ConfigurationManager.tsx 100.00% <100.00%> (ø)
...ConfigurationStatus/useRepoConfigurationStatus.tsx 100.00% <ø> (ø)
src/services/repo/useComponentsBackfilled.tsx 100.00% <ø> (ø)
src/services/repo/useRepoBackfilled.tsx 100.00% <ø> (ø)
src/services/repo/useRepoComponents.tsx 100.00% <ø> (ø)
src/services/repo/useRepoComponentsSelect.tsx 100.00% <100.00%> (ø)
src/services/repo/useRepoFlags.tsx 100.00% <100.00%> (ø)
src/services/repo/useRepoFlagsSelect.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.97% <100.00%> (ø)
Services 99.44% <100.00%> (+<0.01%) ⬆️
Shared 99.80% <ø> (ø)
UI 99.10% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b133ce8...7efd3f7. Read the comment docs.

@codecov-staging
Copy link

codecov-staging bot commented Sep 17, 2024 •
edited by codecov-notifications bot
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3203   +/-   ##
=======================================
  Coverage   99.17%   99.17%           
=======================================
  Files         799      799           
  Lines       14093    14094    +1     
  Branches     3882     3887    +5     
=======================================
+ Hits        13977    13978    +1     
  Misses        107      107           
  Partials        9        9
Files with missing lines Coverage Δ
...tabs/ConfigurationManager/ConfigurationManager.tsx 100.00% <100.00%> (ø)
...ConfigurationStatus/useRepoConfigurationStatus.tsx 100.00% <ø> (ø)
src/services/repo/useComponentsBackfilled.tsx 100.00% <ø> (ø)
src/services/repo/useRepoBackfilled.tsx 100.00% <ø> (ø)
src/services/repo/useRepoComponents.tsx 100.00% <ø> (ø)
src/services/repo/useRepoComponentsSelect.tsx 100.00% <100.00%> (ø)
src/services/repo/useRepoFlags.tsx 100.00% <100.00%> (ø)
src/services/repo/useRepoFlagsSelect.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.97% <100.00%> (ø)
Services 99.44% <100.00%> (+<0.01%) ⬆️
Shared 99.80% <ø> (ø)
UI 99.10% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b133ce8...7efd3f7. Read the comment docs.

@codecov-public-qa Codecov Public QA
Copy link

codecov-public-qa bot commented Sep 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.17%. Comparing base (b133ce8) to head (7efd3f7).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3203   +/-   ##
=======================================
  Coverage   99.17%   99.17%           
=======================================
  Files         799      799           
  Lines       14093    14094    +1     
  Branches     3887     3887           
=======================================
+ Hits        13977    13978    +1     
  Misses        107      107           
  Partials        9        9
Files Coverage Δ
...tabs/ConfigurationManager/ConfigurationManager.tsx 100.00% <100.00%> (ø)
...ConfigurationStatus/useRepoConfigurationStatus.tsx 100.00% <ø> (ø)
src/services/repo/useComponentsBackfilled.tsx 100.00% <ø> (ø)
src/services/repo/useRepoBackfilled.tsx 100.00% <ø> (ø)
src/services/repo/useRepoComponents.tsx 100.00% <ø> (ø)
src/services/repo/useRepoComponentsSelect.tsx 100.00% <100.00%> (ø)
src/services/repo/useRepoFlags.tsx 100.00% <100.00%> (ø)
src/services/repo/useRepoFlagsSelect.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.97% <100.00%> (ø)
Services 99.44% <100.00%> (+<0.01%) ⬆️
Shared 99.80% <ø> (ø)
UI 99.10% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b133ce8...7efd3f7. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Sep 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.17%. Comparing base (b133ce8) to head (7efd3f7).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3203   +/-   ##
=======================================
  Coverage   99.17%   99.17%           
=======================================
  Files         799      799           
  Lines       14093    14094    +1     
  Branches     3882     3887    +5     
=======================================
+ Hits        13977    13978    +1     
  Misses        107      107           
  Partials        9        9
Files with missing lines Coverage Δ
...tabs/ConfigurationManager/ConfigurationManager.tsx 100.00% <100.00%> (ø)
...ConfigurationStatus/useRepoConfigurationStatus.tsx 100.00% <ø> (ø)
src/services/repo/useComponentsBackfilled.tsx 100.00% <ø> (ø)
src/services/repo/useRepoBackfilled.tsx 100.00% <ø> (ø)
src/services/repo/useRepoComponents.tsx 100.00% <ø> (ø)
src/services/repo/useRepoComponentsSelect.tsx 100.00% <100.00%> (ø)
src/services/repo/useRepoFlags.tsx 100.00% <100.00%> (ø)
src/services/repo/useRepoFlagsSelect.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.97% <100.00%> (ø)
Services 99.44% <100.00%> (+<0.01%) ⬆️
Shared 99.80% <ø> (ø)
UI 99.10% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b133ce8...7efd3f7. Read the comment docs.

@codecov-staging
Copy link

codecov-staging bot commented Sep 17, 2024 •
edited
Loading

Bundle Report

Changes will increase total bundle size by 1.11kB (0.02%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-staging-array-push 6.09MB 1.11kB (0.02%) ⬆️

@codecov Codecov
Copy link

codecov bot commented Sep 17, 2024 •
edited
Loading

Bundle Report

Changes will increase total bundle size by 1.11kB (0.02%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-production-array-push 6.09MB 1.11kB (0.02%) ⬆️

@codecov-releaser
Copy link
Contributor

codecov-releaser commented Sep 17, 2024 •
edited
Loading

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
7e96e3a Tue, 17 Sep 2024 04:27:45 GMT Expired Expired
d9d8c06 Mon, 30 Sep 2024 05:01:56 GMT Expired Expired
f6e642c Wed, 02 Oct 2024 23:37:07 GMT Expired Expired
b922568 Thu, 03 Oct 2024 00:02:26 GMT Expired Expired
d92c415 Thu, 03 Oct 2024 01:15:36 GMT Expired Expired
7aa832e Thu, 03 Oct 2024 02:06:23 GMT Expired Expired
54cc7b2 Thu, 03 Oct 2024 03:36:03 GMT Expired Expired
8d53a0b Sat, 05 Oct 2024 01:19:50 GMT Expired Expired
8d53a0b Sat, 05 Oct 2024 01:24:59 GMT Expired Expired
896093b Sat, 05 Oct 2024 01:37:36 GMT Expired Expired
896093b Sat, 05 Oct 2024 01:39:08 GMT Expired Expired
1b1ab39 Mon, 07 Oct 2024 17:00:39 GMT Expired Expired
7efd3f7 Mon, 07 Oct 2024 19:56:07 GMT Cloud Enterprise

@suejung-sentry suejung-sentry marked this pull request as ready for review October 3, 2024 00:33
nicholas-codecov
nicholas-codecov reviewed Oct 3, 2024
View reviewed changes
Copy link
Contributor

@nicholas-codecov nicholas-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, however the preview deploy isn't working and there's bad API calls, wondering if staging is up to date?

Screenshot 2024-10-03 at 09 57 03

@suejung-sentry
Copy link
Contributor Author

suejung-sentry commented Oct 3, 2024 •
edited
Loading

Changes look good, however the preview deploy isn't working and there's bad API calls, wondering if staging is up to date?

@nicholas-codecov , Thanks for reviewing! Yes waiting for this one - codecov/codecov-api#842 - to get reviewed and deployed as a prerequisite to deploying this one. Note I'll need api to get live in DEC (normally just goes out weekly, need to ping Jason if off cycle) before I can merge this one

@nicholas-codecov
Copy link
Contributor

@nicholas-codecov , Thanks for reviewing! Yes waiting for this one - codecov/codecov-api#842 - to get reviewed and deployed as a prerequisite to deploying this one. Note I'll need api to get live in DEC (normally just goes out weekly, need to ping Jason if off cycle) before I can merge this one

Ahh okay, do you mind if I hold off on stamping this until then, just so we don't accidentally merge this?

@suejung-sentry
Copy link
Contributor Author

@nicholas-codecov , Thanks for reviewing! Yes waiting for this one - codecov/codecov-api#842 - to get reviewed and deployed as a prerequisite to deploying this one. Note I'll need api to get live in DEC (normally just goes out weekly, need to ping Jason if off cycle) before I can merge this one

Ahh okay, do you mind if I hold off on stamping this until then, just so we don't accidentally merge this?

Yup, thanks!! I'll ping you for the stamp at that time then!

suejung-sentry
suejung-sentry commented Oct 7, 2024
View reviewed changes
Copy link
Contributor Author

@suejung-sentry suejung-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these are qa screenshots
qa_screenshots.pdf

@suejung-sentry suejung-sentry added this pull request to the merge queue Oct 7, 2024
Merged via the queue into main with commit 4455ce9 Oct 7, 2024
62 checks passed
@suejung-sentry suejung-sentry deleted the sshin/2289 branch October 7, 2024 20:57
@suejung-sentry suejung-sentry mentioned this pull request Oct 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calvin-codecov calvin-codecov calvin-codecov approved these changes

@Alloneway30 Alloneway30 Alloneway30 approved these changes

@nicholas-codecov nicholas-codecov nicholas-codecov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[2.2] Update Gazebo Queries
5 participants
@suejung-sentry @codecov-releaser @nicholas-codecov @Alloneway30 @calvin-codecov