chore: Update layouts/BaseLayout tests to Vitest #3208

nicholas-codecov · 2024-09-19T10:49:01Z

Description

This PR updates the tests in the layouts/BaseLayout directory to Vitest

Requires #3201

Notable Changes

Update BaseLayout tests
Update useUserAccessGate tests
Update InstallationHelpBanner tests
Convert JS index files to TS

…essible to run

codecov-qa · 2024-09-19T10:52:40Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.11%. Comparing base (9d66eb1) to head (61c44ef).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3208   +/-   ##
=======================================
  Coverage   99.10%   99.11%           
=======================================
  Files         799      799           
  Lines       13975    13975           
  Branches     3960     3965    +5     
=======================================
+ Hits        13850    13851    +1     
+ Misses        117      116    -1     
  Partials        8        8

see 1 file with indirect coverage changes

Components	Coverage Δ
Assets	`100.00% <ø> (ø)`
Layouts	`100.00% <ø> (ø)`
Pages	`98.89% <ø> (+0.01%)`	⬆️
Services	`99.41% <ø> (ø)`
Shared	`99.58% <ø> (ø)`
UI	`99.26% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d66eb1...61c44ef. Read the comment docs.

codecov · 2024-09-19T10:52:48Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.11%. Comparing base (9d66eb1) to head (61c44ef).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

@@               Coverage Diff                @@
##               main      #3208        +/-   ##
================================================
+ Coverage   99.10000   99.11000   +0.01000     
================================================
  Files           799        799                
  Lines         13975      13975                
  Branches       3965       3960         -5     
================================================
+ Hits          13850      13851         +1     
+ Misses          117        116         -1     
  Partials          8          8

see 1 file with indirect coverage changes

Components	Coverage Δ
Assets	`100.00% <ø> (ø)`
Layouts	`100.00% <ø> (ø)`
Pages	`98.89% <ø> (+0.01%)`	⬆️
Services	`99.41% <ø> (ø)`
Shared	`99.58% <ø> (ø)`
UI	`99.26% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d66eb1...61c44ef. Read the comment docs.

codecov-notifications · 2024-09-19T10:53:13Z

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3208   +/-   ##
=======================================
  Coverage   99.10%   99.11%           
=======================================
  Files         799      799           
  Lines       13975    13975           
  Branches     3960     3960           
=======================================
+ Hits        13850    13851    +1     
+ Misses        117      116    -1     
  Partials        8        8

see 1 file with indirect coverage changes

Components	Coverage Δ
Assets	`100.00% <ø> (ø)`
Layouts	`100.00% <ø> (ø)`
Pages	`98.89% <ø> (+0.01%)`	⬆️
Services	`99.41% <ø> (ø)`
Shared	`99.58% <ø> (ø)`
UI	`99.26% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d66eb1...61c44ef. Read the comment docs.

codecov-public-qa · 2024-09-19T10:53:21Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.11%. Comparing base (9d66eb1) to head (61c44ef).

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3208   +/-   ##
=======================================
  Coverage   99.10%   99.11%           
=======================================
  Files         799      799           
  Lines       13975    13975           
  Branches     3965     3965           
=======================================
+ Hits        13850    13851    +1     
+ Misses        117      116    -1     
  Partials        8        8

see 1 file with indirect coverage changes

Components	Coverage Δ
Assets	`100.00% <ø> (ø)`
Layouts	`100.00% <ø> (ø)`
Pages	`98.89% <ø> (+0.01%)`	⬆️
Services	`99.41% <ø> (ø)`
Shared	`99.58% <ø> (ø)`
UI	`99.26% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d66eb1...61c44ef. Read the comment docs.

codecov · 2024-09-19T12:39:23Z

Bundle Report

Bundle size has no change ✅

codecov-releaser · 2024-09-19T12:43:03Z

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit	Created	Cloud	Enterprise
`41becb1`	Thu, 19 Sep 2024 12:43:03 GMT	Expired	Expired
`98f91e0`	Thu, 19 Sep 2024 13:00:34 GMT	Expired	Expired
`532ffce`	Thu, 19 Sep 2024 13:13:55 GMT	Expired	Expired
`e25f145`	Thu, 19 Sep 2024 13:45:10 GMT	Expired	Expired
`61c44ef`	Thu, 19 Sep 2024 14:11:24 GMT	Cloud	Enterprise

codecov-staging · 2024-09-19T12:53:47Z

Bundle Report

Bundle size has no change ✅

Bundle name	Size	Change
gazebo-staging-array-push	6.0MB	0 bytes

spalmurray-codecov · 2024-09-19T13:56:07Z

src/layouts/BaseLayout/BaseLayout.test.tsx

- )
+ }),
+ graphql.mutation('updateDefaultOrganization', (info) => {
+ return HttpResponse.json({ data: {} }, { status: 200 })


In App.test.tsx you added { status: 200 } as an example of setting status which I'm cool with, but since 200 is default, IMO we shouldn't make explicitly stating it a pattern across the codebase. Thoughts?

Yea we can remove these

tyty appreciate

spalmurray-codecov

One comment, lgtm otherwise

nicholas-codecov added 30 commits September 18, 2024 08:46

add in vitest

b766325

rename old_ui tests from spec to test for vitest

8a1c7b1

add in data-testid to icon

627b145

temp

dc8fe8d

ignore test test files in craco

3f154bb

add in coverage stuff for vitest

71f0a33

setup CI to run vitest tests

b08164b

whoops didn't mean to commit these

7b06a1e

add names to test runner indexes

b572a9d

set min threads

ce0b6e5

add in reporter all tests

bb488b9

conditionally enable junit test reporter

950d6ac

only include src files in coverage reporting

64c2939

exclude some files from coverage reporting

9917c18

there are some issues with coverage excludes making the files not acc…

cab1973

…essible to run

forgot that I moved the setup file to ts

f5b6466

add --changed to test watch command

d2bd52b

add name to prod uploads for craco and vitest

d120380

tidying up some stuff in the ci

fc5eb5b

disable vitest to see what happens

168ffa4

increase n builds

619bbac

remove generating icons for webpack

84d1276

update ci command

3d6ef25

rename to .jsx because it contains jsx

71f0955

swap from v8 to istanbul for coverage reporting

53616b2

only generate icons for vite, and craco build

d188c3e

small tweaks to the codecov yml config

2a1068d

generate webpack icons before running tests

976ade0

styling tweaks to vitest

0a5ed38

small tweaks to vitest config

e53de7e

nicholas-codecov added 5 commits September 18, 2024 11:36

remove left over log

52fd40c

tweak excludes

31b1335

disable this eslint rule as it seems we need to do the manual cleanup

850a7a8

make sure TS knows about the vi types globally

d8c6af2

sort out vitest with setup stuff as well as loading correct envs

79f70a0

resolve issue with vitest types interferring with craco stuff

9f73de4

nicholas-codecov force-pushed the chore-vitest-update-base-layout-tests branch from d45ce9f to 41becb1 Compare September 19, 2024 12:36

tweak reporters

1c2aebc

nicholas-codecov force-pushed the chore-vitest-update-base-layout-tests branch from 41becb1 to 98f91e0 Compare September 19, 2024 12:51

nicholas-codecov added 5 commits September 19, 2024 10:05

remove test files from coverage reporting

5d6b24e

update BaseLayout test

bc5a324

update useUserAccessGate tests

7317a5e

update InstallationHelpBanner tests

cff7486

update index files from js to ts

532ffce

nicholas-codecov force-pushed the chore-vitest-update-base-layout-tests branch from 98f91e0 to 532ffce Compare September 19, 2024 13:06

Merge branch 'main' into chore-vitest-update-base-layout-tests

e25f145

spalmurray-codecov reviewed Sep 19, 2024

View reviewed changes

spalmurray-codecov approved these changes Sep 19, 2024

View reviewed changes

remove status 200 as it's the default

61c44ef

nicholas-codecov added this pull request to the merge queue Sep 19, 2024

Merged via the queue into main with commit ba1db36 Sep 19, 2024
64 checks passed

nicholas-codecov deleted the chore-vitest-update-base-layout-tests branch September 19, 2024 14:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: Update layouts/BaseLayout tests to Vitest #3208

chore: Update layouts/BaseLayout tests to Vitest #3208

nicholas-codecov commented Sep 19, 2024

codecov-qa bot commented Sep 19, 2024 •

edited

Loading

codecov bot commented Sep 19, 2024 •

edited

Loading

codecov-notifications bot commented Sep 19, 2024 •

edited

Loading

codecov-public-qa bot commented Sep 19, 2024 •

edited

Loading

codecov bot commented Sep 19, 2024 •

edited

Loading

codecov-releaser commented Sep 19, 2024 •

edited

Loading

codecov-staging bot commented Sep 19, 2024 •

edited

Loading

spalmurray-codecov Sep 19, 2024

nicholas-codecov Sep 19, 2024

spalmurray-codecov Sep 19, 2024

spalmurray-codecov left a comment

chore: Update layouts/BaseLayout tests to Vitest #3208

chore: Update layouts/BaseLayout tests to Vitest #3208

Conversation

nicholas-codecov commented Sep 19, 2024

Description

Notable Changes

codecov-qa bot commented Sep 19, 2024 • edited Loading

Codecov Report

codecov bot commented Sep 19, 2024 • edited Loading

Codecov Report

codecov-notifications bot commented Sep 19, 2024 • edited Loading

Codecov Report

codecov-public-qa bot commented Sep 19, 2024 • edited Loading

Codecov Report

codecov bot commented Sep 19, 2024 • edited Loading

Bundle Report

codecov-releaser commented Sep 19, 2024 • edited Loading

✅ Deploy preview for gazebo ready!

codecov-staging bot commented Sep 19, 2024 • edited Loading

Bundle Report

spalmurray-codecov Sep 19, 2024

Choose a reason for hiding this comment

nicholas-codecov Sep 19, 2024

Choose a reason for hiding this comment

spalmurray-codecov Sep 19, 2024

Choose a reason for hiding this comment

spalmurray-codecov left a comment

Choose a reason for hiding this comment

codecov-qa bot commented Sep 19, 2024 •

edited

Loading

codecov bot commented Sep 19, 2024 •

edited

Loading

codecov-notifications bot commented Sep 19, 2024 •

edited

Loading

codecov-public-qa bot commented Sep 19, 2024 •

edited

Loading

codecov bot commented Sep 19, 2024 •

edited

Loading

codecov-releaser commented Sep 19, 2024 •

edited

Loading

codecov-staging bot commented Sep 19, 2024 •

edited

Loading